[feature]: fixes install.sh issues on machine without docker installed #9
Conversation
|
@tiero here is my PR to the issue i tagged you on earlier. Please I would love your feedback |
|
@tiero @altafan @thunderbiscuit Please I am still expecting feedback on this PR |
index.sh
Outdated
|
|
||
| function docker_install_mac(){ | ||
|
|
||
| /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)" |
There was a problem hiding this comment.
I am not convinced we should default to brew to install docker: I would check if brew is there first, if not we can fallback to docker desktop maybe?
There was a problem hiding this comment.
Thank you @tiero ! I would modify this based on your feedback and also look to see if there are other alternatives on macos other than brew that can install docker desktop. Thanks, I would revert and update
There was a problem hiding this comment.
@tiero I have made the update, I also made provision for machines that run on apple silicon chips. At a time convenient for you, please do let me know your thoughts and leave any feedback for me. Kind regards
index.sh
Outdated
| if [ -x "$(command -v docker)" ]; then | ||
| echo "${GREEN} docker has been installed!" | ||
| fi |
There was a problem hiding this comment.
In case the docker is ALREADY installed, we should not show this text.
The issue is that could seem to the user that we installed AGAIN docker, when actually we simply skip.
I tested on my Mac which has Docker already installed and I have this.
Fetching https://github.com/vulpemventures/nigiri/releases/latest...
Latest release tag = v0.4.14
Fetching https://github.com/vulpemventures/nigiri/releases/download/v0.4.14/nigiri-darwin-arm64...
Moving binary to /usr/local/bin...
Setting binary permissions...
Checking for Docker and Docker compose...
docker has been installed!
🍣 Nigiri Bitcoin installed!
There was a problem hiding this comment.
Thanks tiero, I have made this correction. I have also squashed my commit to a single commit for this change. I await further feedbacks and reviews.
Kind regards
…on of nigiri install docker based on the OS of the user's machine
NonsoAmadi10
force-pushed
the
issue-missing-docker-after-installation
branch
from
5ef38fb to
d818b72
Compare
What does this PR do?
install.shissues outlined in this issue when trying to setup nigiriHow should this be tested?