Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6354: do an explicit read from version file to avoid circular reference #3480

Merged
merged 1 commit into from
May 18, 2024

Conversation

jestabro
Copy link
Contributor

Change Summary

Avoid circular reference introduced in #3474
This is in keeping with vyos.system being low-level, precisely so that utils such as is_live_boot may be used elsewhere.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this May 17, 2024
@jestabro
Copy link
Contributor Author

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented May 17, 2024

backport sagitta

✅ Backports have been created

@dmbaturin dmbaturin merged commit 4686ab7 into vyos:current May 18, 2024
7 of 8 checks passed
jestabro added a commit that referenced this pull request May 18, 2024
T6354: do an explicit read from version file to avoid circular reference (backport #3480)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants