Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapter 2 Typst Rewrite #2

Open
wants to merge 5 commits into
base: feat/rewrite
Choose a base branch
from
Open

Chapter 2 Typst Rewrite #2

wants to merge 5 commits into from

Conversation

yd4dev
Copy link

@yd4dev yd4dev commented Aug 23, 2024 •
edited by w-lfchen
Loading

TODO:

  • Translate contents into typst
  • Styling
  • (Fix hyperlinks)

w-lfchen
w-lfchen requested changes Aug 23, 2024
View reviewed changes
Copy link
Owner

@w-lfchen w-lfchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't commit binary files.
i'll add that to the gitignore, good catch

w-lfchen
w-lfchen requested changes Aug 23, 2024
View reviewed changes
Copy link
Owner

@w-lfchen w-lfchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't delete the old pdfs yet.
also, i'd fix hyperlinks after translating everything
styling should be postponed as well so that it can be consistent across all files

@w-lfchen w-lfchen mentioned this pull request Aug 23, 2024
Open
11 tasks
w-lfchen
w-lfchen requested changes Aug 26, 2024
View reviewed changes
Copy link
Owner

@w-lfchen w-lfchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add newlines before every heading.

src/2. Sorting.typ Outdated Show resolved Hide resolved
src/2. Sorting.typ Outdated Show resolved Hide resolved
src/2. Sorting.typ Outdated Show resolved Hide resolved
src/2. Sorting.typ Outdated Show resolved Hide resolved
@yd4dev @w-lfchen
fix: apply suggestions
3b283fa 
Co-authored-by: Wölfchen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w-lfchen w-lfchen w-lfchen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yd4dev @w-lfchen