Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify where remote resources can be referenced #1859

Merged
merged 4 commits into from
Oct 25, 2021
Merged

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Oct 18, 2021

Implements the proposal in #1857 (comment)

Fixes #1857


Preview | Diff

- audio from audio/track elements
- video from video/track elements
- data from scripting APIs
- fonts fron @font-face rules
@mattgarrish
Copy link
Member Author

I'm going to critique my own pull request and question if I've forgotten Media Overlays. Although hosting the synched audio outside the container doesn't strike me as a great idea, as there's no guarantee the reading system will grab the files and it could delay/interrupt playback, it has been allowed up until now.

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you that we have to be consistent v.a.v. the media overlay references. I believe we should add those to the mix.

epub33/core/index.html Outdated Show resolved Hide resolved
@mattgarrish
Copy link
Member Author

One other option not covered is using @import or the link element to import Google Fonts. We should allow these, too.

I think that covers everything, though.

@iherman
Copy link
Member

iherman commented Oct 19, 2021

One issue that did come up during the call: do we have to mention <object>? I can imagine that there are older epub content out there that rely on it rather than using the <video> or the <audio> elements.

I do not think that we should start into allowing that, too; all this may become too much of a spaghetti code. But we may want to think about a note saying that users of <object> for video and/or audio should use the more recent <video>/<audio> elements instead.

Just a thought. I won't have sleepless nights over just leaving this unmentioned.

@mattgarrish
Copy link
Member Author

I can imagine that there are older epub content out there that rely on it rather than using the <video> or the <audio> elements.

If they do, they probably have bigger problems than the object tag. To my knowledge, object was only ever used to embed flash videos, and flash video is all but dead at this point. I don't believe they even run in browsers anymore because of the security issues. It was also used to reference YouTube flash videos back when you could pull out the url to the swf file, but those days are long gone now, too.

That's why I don't think we should be concerned about allowing remote resources from object (or embed). The days of audio/video requiring plugins to work are pretty much over.

No strong opinion about a note, but I'd tend to think most authors would naturally progress old content to audio/video even if we say nothing.

@iherman
Copy link
Member

iherman commented Oct 19, 2021

No strong opinion about a note, but I'd tend to think most authors would naturally progress old content to audio/video even if we say nothing.

I am fine with this.

@mattgarrish mattgarrish merged commit e405cfb into main Oct 25, 2021
@mattgarrish mattgarrish deleted the fix/issue-1857 branch October 25, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify where remote resource references are allowed
3 participants