Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finalResponseHeadersStart which is always the 2xx/4xx/5xx response. #408

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Nov 4, 2024

responseStart now returns firstInterimResponseStart as before, but falls back to finalResponseHeadersStart if there is no interim response.

Closes #345

responseStart now returns `firstInterimResponseStart` as before, but
falls back to `finalResponseHeadersStart` if there is no interim response.

Closes #345
index.html Show resolved Hide resolved
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noamr noamr merged commit 058d390 into gh-pages Nov 4, 2024
2 checks passed
@noamr noamr deleted the firp branch November 4, 2024 12:14
@tunetheweb
Copy link
Member

We probably should update the diagram for this: https://w3c.github.io/resource-timing/#attribute-descriptions

Though it's quite old anyway and has diverged from the Navigation Timing one: https://w3c.github.io/navigation-timing/#processing-model

@tunetheweb
Copy link
Member

Raised these:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding finalResponseHeaders{Start|End} times
4 participants