Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datagrams.createWritable() #620

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add datagrams.createWritable() #620

wants to merge 4 commits into from

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Oct 22, 2024 •
edited by pr-preview bot
Loading

Partial fix for #610.

Preview | Diff

@jan-ivar jan-ivar self-assigned this Oct 22, 2024
@jan-ivar jan-ivar mentioned this pull request Oct 22, 2024
Closed
@jan-ivar
Copy link
Member Author

Meeting:

  • This breaks backwards compatibility. Maybe leave wt.datagrams.writable alone for now.
  • Editors can integrate once this is done.

@jan-ivar jan-ivar changed the title Replace datagrams.writable with datagrams.createWritable() Add datagrams.createWritable() Nov 20, 2024
@jan-ivar jan-ivar mentioned this pull request Dec 5, 2024
Open
@jan-ivar
Copy link
Member Author

jan-ivar commented Dec 5, 2024

This needs a bit more surgery to the algorithms. Will ping folks for review when that's done.

@jan-ivar jan-ivar marked this pull request as draft December 5, 2024 14:40
@jan-ivar jan-ivar marked this pull request as ready for review December 17, 2024 14:51
@jan-ivar jan-ivar requested a review from nidhijaju December 17, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidhijaju nidhijaju Awaiting requested review from nidhijaju

Assignees

@jan-ivar jan-ivar

Labels
Editors can integrate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jan-ivar