-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade depdencies #249
base: develop
Are you sure you want to change the base?
Upgrade depdencies #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the code wouldn't run in my computer (windows 10) I created a docker-compose so I could use this repo.
Eventually I decided to fix all the dependencies so I could run it locally, so I fixed and tested it all the way.
It wasn't an easy one. I encountered some difficult breaking changes and some very unclear indivisible exceptions but in the end I succeeded :)
I learnt a lot by reading your code style, and as many people mentioned it gave me some great notions about how backend development should look like.
I hope this pull request will assist you to fix some major issues that prevent people from using this wonderful repository and I'm here to reply on any questions you have 😃
@Tyderion @dweber019 @hirsch88
cool! I ran it locally and finally, it worked. Those outdated dependencies didn't allow me to start this boilerplate locally. But with your pr it worked. |
though I had to do a slight change in order to make import commander from 'commander'; // < --- NEW works |
Upgrading dependencies ⛑️:
☑️bcrypt
☑️class-validator
☑️dataloader
☑️graphql
☑️typedi
☑️typeorm
☑️typeorm-seeding
☑️sqlite
☑️typescript
adding docker-compose for running web-server with postgres & postgres admin console
✳️ Tested both with docker & locally on windows 10