fix: panic during removePubSubTopic (#765)

waku-org · Sep 22, 2023 · 9f4754d · 9f4754d
1 parent a84701a
commit 9f4754d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/waku/v2/peerstore/waku_peer_store.go b/waku/v2/peerstore/waku_peer_store.go
@@ -171,8 +171,12 @@ func (ps *WakuPeerstoreImpl) RemovePubSubTopic(p peer.ID, topic string) error {
 	}
 
 	for i := range existingTopics {
-		existingTopics = append(existingTopics[:i], existingTopics[i+1:]...)
+		if existingTopics[i] == topic {
+			existingTopics = append(existingTopics[:i], existingTopics[i+1:]...)
+			break
+		}
 	}
+
 	err = ps.SetPubSubTopics(p, existingTopics)
 	if err != nil {
 		return err