Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: peermanager tests coverage improvement #1035

Merged
merged 36 commits into from
Mar 18, 2024
Merged

chore: peermanager tests coverage improvement #1035

merged 36 commits into from
Mar 18, 2024

Conversation

romanzac
Copy link
Collaborator

Description

Batch of tests for Waku Peermanager to improve coverage

Changes

Tests available to run:
cd go-waku/waku/v2/peermanager
go test

@status-im-auto
Copy link

status-im-auto commented Feb 17, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (33)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 371e35c #1 2024-02-17 04:32:45 ~1 min nix-flake 📄log
✔️ 4deaa68 #2 2024-02-17 04:34:51 ~2 min nix-flake 📄log
✔️ 69a0188 #3 2024-02-19 06:42:08 ~1 min nix-flake 📄log
✔️ a8e8856 #4 2024-02-19 08:50:58 ~2 min nix-flake 📄log
✔️ 34b2d58 #5 2024-02-20 05:57:20 ~1 min nix-flake 📄log
✔️ a911e5a #6 2024-02-20 06:14:08 ~2 min nix-flake 📄log
✔️ 0091a52 #7 2024-02-22 05:28:23 ~1 min nix-flake 📄log
✔️ 8d524cd #8 2024-02-24 02:29:21 ~1 min nix-flake 📄log
✔️ b8b39a0 #9 2024-02-26 05:29:08 ~1 min nix-flake 📄log
✔️ 20760e3 #10 2024-02-26 08:39:50 ~1 min nix-flake 📄log
✔️ 8e28edd #11 2024-02-29 11:38:18 ~1 min nix-flake 📄log
✔️ 4de04d5 #12 2024-03-02 02:47:40 ~1 min nix-flake 📄log
✔️ 2f7b6c6 #13 2024-03-02 04:29:36 ~1 min nix-flake 📄log
✔️ f74bb4e #14 2024-03-04 02:17:19 ~1 min nix-flake 📄log
✔️ 4b6f6d2 #15 2024-03-04 08:15:39 ~1 min nix-flake 📄log
✔️ d3acab7 #16 2024-03-04 09:56:49 ~1 min nix-flake 📄log
✔️ 9640a8c #17 2024-03-05 07:23:50 ~1 min nix-flake 📄log
✔️ ba2f8b9 #18 2024-03-08 08:37:19 ~2 min nix-flake 📄log
✔️ b70a0be #19 2024-03-08 08:48:01 ~1 min nix-flake 📄log
✔️ 7e5138b #20 2024-03-08 09:05:51 ~1 min nix-flake 📄log
✔️ 621b5e1 #21 2024-03-09 01:47:33 ~1 min nix-flake 📄log
✔️ 1faed8b #22 2024-03-09 08:24:01 ~1 min nix-flake 📄log
✔️ ae0e73a #23 2024-03-11 06:12:56 ~1 min nix-flake 📄log
✔️ dca4502 #24 2024-03-11 13:36:52 ~1 min nix-flake 📄log
✔️ e133ffb #25 2024-03-11 13:53:48 ~1 min nix-flake 📄log
✔️ 6b2d743 #26 2024-03-12 05:10:52 ~1 min nix-flake 📄log
✔️ d6fb227 #27 2024-03-12 11:38:01 ~2 min nix-flake 📄log
✔️ dfdde56 #28 2024-03-12 11:56:48 ~1 min nix-flake 📄log
✔️ 6b94d07 #29 2024-03-12 12:47:03 ~1 min nix-flake 📄log
✔️ 0372719 #30 2024-03-13 10:31:34 ~1 min nix-flake 📄log
✔️ ce77fd6 #31 2024-03-14 12:39:03 ~1 min nix-flake 📄log
✔️ 6811fc6 #32 2024-03-14 12:46:38 ~2 min nix-flake 📄log
✔️ f8a67f8 #33 2024-03-15 01:58:38 ~1 min nix-flake 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0d4cb71 #34 2024-03-16 01:14:02 ~1 min nix-flake 📄log
✔️ 86fbbff #35 2024-03-16 01:17:19 ~1 min nix-flake 📄log

@romanzac romanzac marked this pull request as ready for review March 4, 2024 09:54
romanzac added 3 commits March 8, 2024 16:34
@romanzac
fix: simplify test handle peer topic event
ba2f8b9 
- check peers were added to topic related Wakustore
- check connectedness
@romanzac
fix: simplify test handle relay topic subscription
b70a0be
@romanzac
fix: close event loop gracefully
7e5138b 
- TestHandleRelayTopicSubscription
@romanzac romanzac mentioned this pull request Mar 8, 2024
Closed
@romanzac romanzac requested a review from chaitanyaprem March 11, 2024 09:11
@romanzac romanzac requested a review from chaitanyaprem March 12, 2024 13:00
@romanzac romanzac requested a review from chaitanyaprem March 13, 2024 10:46
@romanzac romanzac mentioned this pull request Mar 14, 2024
Open
@romanzac romanzac mentioned this pull request Mar 15, 2024
Closed
chaitanyaprem
chaitanyaprem reviewed Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI issues need to be fixed.

@romanzac
Copy link
Collaborator Author

bug: metadata might not always be available #1055

I know. Right now we are blocked on #1055 I cannot make test pass without this issue to resolve. It is not big change I assume.

@romanzac romanzac requested a review from chaitanyaprem March 16, 2024 01:43
chaitanyaprem
chaitanyaprem approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanzac romanzac merged commit 4b9e363 into master Mar 18, 2024
12 checks passed
@romanzac romanzac deleted the chore-peermanager-tests-coverage-improvement branch March 18, 2024 08:22
@romanzac romanzac restored the chore-peermanager-tests-coverage-improvement branch March 18, 2024 08:42
romanzac added a commit that referenced this pull request Mar 18, 2024
@romanzac
Revert "chore: peermanager tests coverage improvement (#1035)"
a40a491 
This reverts commit 4b9e363.
@romanzac romanzac deleted the chore-peermanager-tests-coverage-improvement branch March 18, 2024 10:51
@romanzac
Copy link
Collaborator Author

Flaky service slot tests fixed at #1058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos richard-ramos is a code owner

Assignees

@romanzac romanzac

Labels
None yet
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romanzac @status-im-auto @chaitanyaprem