Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: peer exchange tests coverage improvement #1046

Merged
merged 9 commits into from
Mar 11, 2024

Conversation

romanzac
Copy link
Collaborator

@romanzac romanzac commented Mar 7, 2024

Description
Batch of tests for Waku peer exchange to improve coverage

Changes
Tests available to run:
cd go-waku/waku/v2/protocol/peer_exchange
go test

@status-im-auto
Copy link

status-im-auto commented Mar 7, 2024

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 71878e3 #1 2024-03-07 13:18:17 ~2 min nix-flake 📄log
✔️ f0cfb6a #2 2024-03-11 06:09:55 ~1 min nix-flake 📄log
✔️ 552d45a #3 2024-03-11 06:13:55 ~1 min nix-flake 📄log
✔️ ac28c93 #4 2024-03-11 06:18:49 ~1 min nix-flake 📄log
✔️ e19d844 #5 2024-03-11 06:24:13 ~1 min nix-flake 📄log
✔️ f7ac589 #6 2024-03-11 08:20:07 ~1 min nix-flake 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 726acc7 #7 2024-03-11 13:06:40 ~1 min nix-flake 📄log
✔️ 2e8a07a #8 2024-03-11 13:28:29 ~1 min nix-flake 📄log

- remove unnecessary client's start
- remove pm3.SetPeerConnector()
- pxPeerConn3 needs to start
- lower waiting time
- reduce logging
@romanzac romanzac marked this pull request as ready for review March 11, 2024 06:38
@romanzac romanzac requested a review from richard-ramos as a code owner March 11, 2024 06:38
@romanzac romanzac merged commit bdf10a4 into master Mar 11, 2024
12 checks passed
@romanzac romanzac deleted the chore-peer-exchange-tests-coverage-improvement branch March 11, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants