-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: peer exchange tests coverage improvement #1046
Merged
romanzac
merged 9 commits into
master
from
chore-peer-exchange-tests-coverage-improvement
Mar 11, 2024
Merged
chore: peer exchange tests coverage improvement #1046
romanzac
merged 9 commits into
master
from
chore-peer-exchange-tests-coverage-improvement
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- with some debug info
Jenkins BuildsClick to see older builds (6)
|
- remove unnecessary client's start - remove pm3.SetPeerConnector() - pxPeerConn3 needs to start - lower waiting time - reduce logging
richard-ramos
approved these changes
Mar 11, 2024
- remove some commented lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Batch of tests for Waku peer exchange to improve coverage
Changes
Tests available to run:
cd go-waku/waku/v2/protocol/peer_exchange
go test