Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: discv5 tests coverage improvement #1051

Merged
merged 18 commits into from
Mar 26, 2024

Conversation

romanzac
Copy link
Collaborator

Description

Batch of tests for Waku Discv5 to improve coverage

Changes

Tests available to run:
cd go-waku/waku/v2/discv5
go test

@status-im-auto
Copy link

status-im-auto commented Mar 13, 2024

Jenkins Builds

Click to see older builds (16)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cc9f732 #1 2024-03-13 12:11:04 ~2 min nix-flake 📄log
✔️ d5ef55d #2 2024-03-13 12:16:34 ~1 min nix-flake 📄log
✔️ a527875 #3 2024-03-14 07:31:12 ~1 min nix-flake 📄log
✔️ 9ef832f #4 2024-03-14 07:39:46 ~1 min nix-flake 📄log
✔️ db80896 #5 2024-03-14 11:18:16 ~1 min nix-flake 📄log
✔️ cfebb1a #6 2024-03-15 05:40:51 ~1 min nix-flake 📄log
✔️ 444c1b9 #7 2024-03-15 06:06:28 ~2 min nix-flake 📄log
✔️ 292026d #8 2024-03-15 06:22:44 ~1 min nix-flake 📄log
✔️ fbd5d02 #9 2024-03-15 06:30:50 ~1 min nix-flake 📄log
✔️ 1e2da9a #10 2024-03-15 06:48:20 ~1 min nix-flake 📄log
✔️ f1e4c1b #11 2024-03-15 06:58:09 ~1 min nix-flake 📄log
✔️ cf69e21 #12 2024-03-15 07:11:40 ~1 min nix-flake 📄log
✔️ dcb52af #13 2024-03-15 10:51:50 ~2 min nix-flake 📄log
✔️ 12c4695 #14 2024-03-15 10:53:47 ~1 min nix-flake 📄log
✔️ b2857a2 #15 2024-03-18 12:16:32 ~2 min nix-flake 📄log
✔️ 6eef407 #16 2024-03-20 04:14:22 ~1 min nix-flake 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5a6cca6 #17 2024-03-22 04:31:02 ~1 min nix-flake 📄log
✔️ ed0bfce #18 2024-03-26 00:03:20 ~2 min nix-flake 📄log

@romanzac romanzac marked this pull request as ready for review March 15, 2024 10:56
waku/v2/discv5/discover_test.go Show resolved Hide resolved
waku/v2/discv5/discover_test.go Show resolved Hide resolved
waku/v2/discv5/discover_test.go Show resolved Hide resolved
waku/v2/discv5/discover_test.go Show resolved Hide resolved
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanzac romanzac merged commit 83efe65 into master Mar 26, 2024
11 of 12 checks passed
@romanzac romanzac deleted the chore-discv5-tests-coverage-improvement branch March 26, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants