You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why is this branch showing soo much diff with master?
Let us not merge when diff is like this..it means the git tree is probably messed up.
Ideally, we should rebase from master, pass CI and then merge it.
Why is this branch showing soo much diff with master? Let us not merge when diff is like this..it means the git tree is probably messed up. Ideally, we should rebase from master, pass CI and then merge it.
Hopefully nothing got messed up.
This is what I have done. Rebased from master, passed CI and then merged. No worries.
Why is this branch showing soo much diff with master? Let us not merge when diff is like this..it means the git tree is probably messed up. Ideally, we should rebase from master, pass CI and then merge it.
Hopefully nothing got messed up.
This is what I have done. Rebased from master, passed CI and then merged. No worries.
Oh, interesting...in that case the diff shouldn't be this big right
Why is this branch showing soo much diff with master? Let us not merge when diff is like this..it means the git tree is probably messed up. Ideally, we should rebase from master, pass CI and then merge it.
Hopefully nothing got messed up.
This is what I have done. Rebased from master, passed CI and then merged. No worries.
Oh, interesting...in that case the diff shouldn't be this big right
I remember I've done merge at some point too. What is interesting, the final merge into master has normal (expected) diff a453c02 My IDE also shows the same.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Batch of tests for Waku sharding functionality to extend existing tests
Changes
Tests available to run:
cd go-waku/waku/v2/node
go test