Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate lightpush requests #1082

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Conversation

richard-ramos
Copy link
Member

Description

Validates the request format when doing a lightpush request

Issue

closes #1079

@status-im-auto
Copy link

status-im-auto commented Apr 8, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c868b31 #1 2024-04-08 10:12:15 ~1 min nix-flake 📄log
✔️ 9a5f658 #2 2024-04-08 10:15:43 ~1 min nix-flake 📄log
✔️ f1a6d21 #3 2024-04-09 06:06:05 ~1 min nix-flake 📄log
✔️ e6e4c83 #4 2024-04-09 13:43:26 ~1 min nix-flake 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 179244e #5 2024-04-15 12:58:03 ~1 min nix-flake 📄log
✔️ 6597001 #6 2024-04-15 13:20:58 ~1 min nix-flake 📄log

Copy link

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos force-pushed the rest/validate-lp-request branch from f1a6d21 to e6e4c83 Compare April 9, 2024 13:41
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit 46b4efe into master Apr 15, 2024
11 of 12 checks passed
@richard-ramos richard-ramos deleted the rest/validate-lp-request branch April 15, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: missing RequestId field error when lightpush has unexpected payload of content topic
4 participants