Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pubsub topic to WakuMessageKeyValue #1097

Merged
merged 2 commits into from
May 9, 2024

Conversation

richard-ramos
Copy link
Member

Description

Adds the pubsub topic, to match vacp2p/rfc@5d69ab5

@status-im-auto
Copy link

status-im-auto commented May 7, 2024

Jenkins Builds

Click to see older builds (2)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b0d115b #1 2024-05-07 18:30:27 ~1 min nix-flake 📄log
✔️ 1ca0f08 #2 2024-05-08 20:42:52 ~2 min nix-flake 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c241bf2 #3 2024-05-08 20:46:17 ~2 min nix-flake 📄log
✔️ bdfee33 #4 2024-05-08 20:52:28 ~2 min nix-flake 📄log

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the comment needs to be addressed

waku/v2/protocol/store/pb/storev3.proto Show resolved Hide resolved
@richard-ramos richard-ramos force-pushed the feat/msg-pubsubtopic branch from b0d115b to 1ca0f08 Compare May 8, 2024 20:39
@richard-ramos richard-ramos force-pushed the feat/msg-pubsubtopic branch from 1ca0f08 to c241bf2 Compare May 8, 2024 20:43
@richard-ramos richard-ramos merged commit febeb6c into master May 9, 2024
12 checks passed
@richard-ramos richard-ramos deleted the feat/msg-pubsubtopic branch May 9, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants