fix: parallelize filter subs to different peers #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
chaitanyaprem
force-pushed
the
fix/parallel-filter-sub
branch
from
4672a7a to
f7adb0a
Compare
chaitanyaprem
force-pushed
the
fix/parallel-filter-sub
branch
from
58d2ad4 to
81d539c
Compare
richard-ramos
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that since we use 2 peers to subscribe for a filter and each subscription request it sent in sequence which causes delay in case first one times-out due to unreachability of peer.
@jm-clius thanks for hint yesterday about parallel subscriptions that made me review this part of the code.