Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move filter manager from status-go to go-waku #1177

Merged
merged 1 commit into from
Aug 6, 2024
Merged

chore: move filter manager from status-go to go-waku #1177

merged 1 commit into from
Aug 6, 2024

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Aug 1, 2024 •
edited
Loading

  • migrate filter-manager from status-go to api
  • Write tests for filter manager

@richard-ramos richard-ramos force-pushed the missing-messages branch 2 times, most recently from 52a6bfe to f08939e Compare August 1, 2024 13:33
Base automatically changed from missing-messages to master August 1, 2024 14:39
@chaitanyaprem chaitanyaprem force-pushed the refactor/filter-mgr branch 3 times, most recently from 05f92df to 89fbf19 Compare August 5, 2024 07:40
richard-ramos
richard-ramos approved these changes Aug 5, 2024
View reviewed changes
waku/v2/api/filter/filter_manager.go Outdated Show resolved Hide resolved
@chaitanyaprem chaitanyaprem marked this pull request as ready for review August 6, 2024 03:55
kaichaosun
kaichaosun approved these changes Aug 6, 2024
View reviewed changes
waku/v2/api/filter/filter_manager.go Outdated Show resolved Hide resolved
waku/v2/api/filter/filter_manager.go Outdated Show resolved Hide resolved
@chaitanyaprem
Copy link
Collaborator Author

@richard-ramos any idea why storev3 tests keep failing with some docker-compose not found error.

@chaitanyaprem
Copy link
Collaborator Author

Merging as tests passed locally and also did some dogfooding with status-desktop.
Also, sure that CI issue is due to something else entirely.

@chaitanyaprem chaitanyaprem merged commit f3560ce into master Aug 6, 2024
9 of 12 checks passed
@chaitanyaprem chaitanyaprem deleted the refactor/filter-mgr branch August 6, 2024 07:40
@chaitanyaprem chaitanyaprem mentioned this pull request Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaichaosun kaichaosun kaichaosun approved these changes

@richard-ramos richard-ramos richard-ramos approved these changes

@plopezlpz plopezlpz Awaiting requested review from plopezlpz

Assignees

@chaitanyaprem chaitanyaprem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaitanyaprem @richard-ramos @kaichaosun