feat: filter rate limit #1258
Merged
feat: filter rate limit #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (9)
|
richard-ramos
force-pushed
the
feat/rate-limit
branch
from
c7f7071 to
440b816
Compare
Also includes refactor to have a rate limiter per peer with ttl
richard-ramos
force-pushed
the
feat/rate-limit
branch
from
440b816 to
5403100
Compare
kaichaosun
reviewed
Nov 26, 2024
waku/v2/protocol/filter/options.go
Outdated
| } | ||
|
|
||
| Option func(*FilterParameters) | ||
| FullNodeOption func(*FilterFullNodeParameters) |
There was a problem hiding this comment.
Should be FilterNodeOption.
There was a problem hiding this comment.
I used FullNodeOption because both lightnode and fullnode have their own options, also, using Filter stutters when you use the package name due to repeating the word "filter", i.e. "filter.FilterFullNodeOptionvsfilter.FullNodeOption`.
Hm. I should change the parameters struct name too.
richard-ramos
force-pushed
the
feat/rate-limit
branch
from
a4251a9 to
e37768a
Compare
richard-ramos
force-pushed
the
feat/rate-limit
branch
from
a6359c4 to
955e484
Compare
kaichaosun
approved these changes
Nov 29, 2024
richard-ramos
force-pushed
the
feat/rate-limit
branch
3 times, most recently
from
d1499b5 to
3828f31
Compare
richard-ramos
force-pushed
the
feat/rate-limit
branch
from
3828f31 to
366e0dd
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes refactor to have a rate limiter per peer with TTL
cc: @fryorcraken