fix: filter network change #1270
Draft
+59
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kaichaosun
reviewed
Dec 24, 2024
| // OnConnectionStatusChange to be triggered when connection status change is detected either from offline to online or vice-versa | ||
| // Note that pubsubTopic specific change can be triggered by specifying pubsubTopic, | ||
| // if pubsubTopic is empty it indicates complete connection status change such as node went offline or came back online. | ||
| func (mgr *FilterManager) OnConnectionStatusChange(pubsubTopic string, newStatus bool) { | ||
| func (mgr *FilterManager) OnConnectionStatusChange(pubsubTopic string, newStatus bool, connType byte) { |
There was a problem hiding this comment.
Maybe an enum type for connType for readability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there is a network type change i.e from wifi to 4G even if it involves an intermediary transition to offline, then unsubscribe and resubscribe all filters.
This is to avoid filter-push issue noticed as per https://discord.com/channels/1110799176264056863/1111541184490393691/1318842541436829717.
Changes
Tests
Testing in progress