Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rln-relay): docs and docker #733

Merged
merged 1 commit into from
Sep 14, 2023
Merged

chore(rln-relay): docs and docker #733

merged 1 commit into from
Sep 14, 2023

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Sep 13, 2023 •
edited
Loading

Description

Updates docs and docker images to work with latest RLN changes

Changes

  • Fix RLN example
  • Replace Alpine by Debian to allow building latest go-waku version with RLN enabled
  • Increase go version in README.md badge
  • Added / updated RLN docs
  • Set correct RLN contract address
  • Add error when keystore contains 0 credentials

Issue

Part of #655

@richard-ramos richard-ramos added the E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details label Sep 13, 2023
@status-im-auto
Copy link

status-im-auto commented Sep 13, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (24)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d4dd554 #1 2023-09-13 23:15:02 ~1 min nix-flake 📄log
✔️ d4dd554 #1 2023-09-13 23:15:34 ~2 min linux 📦deb
✖️ d4dd554 #1 2023-09-13 23:15:59 ~2 min tests 📄log
✔️ d4dd554 #1 2023-09-13 23:16:21 ~3 min tests 📄log
✔️ d4dd554 #1 2023-09-13 23:17:19 ~4 min android 📦tgz
✔️ d4dd554 #1 2023-09-13 23:18:24 ~5 min ios 📦tgz
✔️ d4dd554 #2 2023-09-14 13:03:56 ~17 sec nix-flake 📄log
✔️ d4dd554 #2 2023-09-14 13:04:30 ~51 sec tests 📄log
✔️ d4dd554 #2 2023-09-14 13:04:33 ~54 sec linux 📦deb
✖️ d4dd554 #2 2023-09-14 13:05:12 ~1 min tests 📄log
✔️ d4dd554 #2 2023-09-14 13:06:35 ~3 min android 📦tgz
✔️ d4dd554 #2 2023-09-14 13:07:37 ~4 min ios 📦tgz
❌ 6bad422 #3 2023-09-14 17:29:11 ~48 sec linux 📄log
✔️ 6bad422 #3 2023-09-14 17:29:42 ~1 min tests 📄log
✔️ 6bad422 #3 2023-09-14 17:30:16 ~1 min nix-flake 📄log
✔️ 6bad422 #3 2023-09-14 17:31:56 ~3 min android 📦tgz
✔️ 6bad422 #3 2023-09-14 17:32:40 ~4 min ios 📦tgz
✖️ 6bad422 #3 2023-09-14 17:33:27 ~5 min tests 📄log
✔️ 03a2d16 #4 2023-09-14 18:06:24 ~2 min nix-flake 📄log
❌ 03a2d16 #4 2023-09-14 18:06:35 ~2 min linux 📄log
✖️ 03a2d16 #4 2023-09-14 18:07:08 ~2 min tests 📄log
✔️ 03a2d16 #4 2023-09-14 18:07:29 ~3 min tests 📄log
✔️ 03a2d16 #4 2023-09-14 18:07:46 ~3 min ios 📦tgz
✔️ 03a2d16 #4 2023-09-14 18:08:00 ~3 min android 📦tgz
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ acf7fff #5 2023-09-14 18:17:00 ~41 sec linux 📄log
✔️ acf7fff #5 2023-09-14 18:18:10 ~1 min nix-flake 📄log
✔️ acf7fff #5 2023-09-14 18:18:16 ~1 min tests 📄log
✔️ acf7fff #5 2023-09-14 18:19:22 ~3 min android 📦tgz
✔️ acf7fff #5 2023-09-14 18:19:30 ~3 min tests 📄log
✔️ acf7fff #5 2023-09-14 18:19:39 ~3 min ios 📦tgz
✔️ bbb479c #6 2023-09-14 18:20:23 ~48 sec tests 📄log
✔️ bbb479c #6 2023-09-14 18:20:23 ~1 min linux 📦deb
✔️ bbb479c #6 2023-09-14 18:21:13 ~1 min tests 📄log
✔️ bbb479c #6 2023-09-14 18:21:16 ~1 min nix-flake 📄log
✔️ bbb479c #6 2023-09-14 18:23:01 ~3 min android 📦tgz
✔️ bbb479c #6 2023-09-14 18:30:37 ~11 min ios 📦tgz

harsh-98
harsh-98 approved these changes Sep 14, 2023
View reviewed changes
docs/operators/how-to/run-with-rln.md Outdated Show resolved Hide resolved
chaitanyaprem
chaitanyaprem approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from few minor comments.

Dockerfile Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/operators/how-to/run-with-rln.md Outdated Show resolved Hide resolved
docs/operators/how-to/run-with-rln.md Outdated Show resolved Hide resolved
docs/operators/how-to/run-with-rln.md Show resolved Hide resolved
docs/operators/how-to/run-with-rln.md Outdated Show resolved Hide resolved
@chaitanyaprem
Copy link
Collaborator

Tests seem to have failed in CI. Need to address that.

Base automatically changed from enable-rln-default to master September 14, 2023 13:03
@richard-ramos richard-ramos force-pushed the rln-docs branch 3 times, most recently from 03a2d16 to acf7fff Compare September 14, 2023 18:16
@richard-ramos richard-ramos merged commit e1a84aa into master Sep 14, 2023
@richard-ramos richard-ramos deleted the rln-docs branch September 14, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh-98 harsh-98 harsh-98 approved these changes

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

Assignees
No one assigned
Labels
E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richard-ramos @status-im-auto @chaitanyaprem @harsh-98