Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rln-relay): use zerokit 0.3.4 to obtain number of leaves set in merkle tree #743

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

richard-ramos
Copy link
Member

Description

Use zerokit 0.3.4 to obtain number of commitments inserted in the RLN merkle tree, instead of calculating the number of members based on the event index

Issue

Part of #655

@richard-ramos richard-ramos added the E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details label Sep 15, 2023
@status-im-auto
Copy link

status-im-auto commented Sep 15, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 8c78491 #1 2023-09-15 00:07:03 ~13 sec nix-flake 📄log
✔️ 8c78491 #1 2023-09-15 00:09:11 ~2 min linux 📦deb
✔️ 8c78491 #1 2023-09-15 00:09:45 ~2 min tests 📄log
✔️ 8c78491 #1 2023-09-15 00:09:56 ~3 min tests 📄log
✔️ 8c78491 #1 2023-09-15 00:10:47 ~3 min android 📦tgz
✔️ 8c78491 #1 2023-09-15 00:11:16 ~4 min ios 📦tgz
✔️ f3341a0 #2 2023-09-15 14:09:56 ~1 min linux 📦deb
✔️ f3341a0 #2 2023-09-15 14:10:55 ~2 min nix-flake 📄log
✔️ f3341a0 #2 2023-09-15 14:11:39 ~2 min tests 📄log
✔️ f3341a0 #2 2023-09-15 14:11:54 ~3 min tests 📄log
✔️ f3341a0 #2 2023-09-15 14:12:09 ~3 min android 📦tgz
✔️ f3341a0 #2 2023-09-15 14:12:48 ~4 min ios 📦tgz

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaitanyaprem
Copy link
Collaborator

Looks like vendor SHA needs to be updated as nix build failed.

@richard-ramos
Copy link
Member Author

Looks like vendor SHA needs to be updated as nix build failed.

yeah, this is extremely annoying. Might take some time next week to try and make this dynamic.

@harsh-98
Copy link
Contributor

lgtm

@richard-ramos richard-ramos merged commit 22b0978 into master Sep 15, 2023
1 check passed
@richard-ramos richard-ramos deleted the leaves_Set branch September 15, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants