Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat : handle dynamic peer topic sub unsub #751

Merged
merged 10 commits into from
Sep 19, 2023
Merged

Feat : handle dynamic peer topic sub unsub #751

merged 10 commits into from
Sep 19, 2023

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Sep 18, 2023 •
edited
Loading

Description

Handle dynamic Join and leave of a peer to a pubSubTopic as per #727 .

Changes

  • Expose PeerJoin and Leave events via relay eventBus
  • PeerManager to listen for these events and update peer metadata accordingly in peerStore
  • Pending go.mod updates in noise example

Tests

Ran all unit tests with and without race flag.
Validated events by running multiple service nodes locally and connecting with each other.

@status-im-auto
Copy link

status-im-auto commented Sep 18, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (32)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4b10ab7 #1 2023-09-18 11:53:21 ~3 min linux 📦deb
✔️ 4b10ab7 #1 2023-09-18 11:53:49 ~3 min nix-flake 📄log
✔️ 4b10ab7 #1 2023-09-18 11:54:28 ~4 min android 📦tgz
✖️ 4b10ab7 #1 2023-09-18 11:54:42 ~4 min tests 📄log
✖️ 4b10ab7 #1 2023-09-18 11:55:15 ~4 min tests 📄log
✔️ 4b10ab7 #1 2023-09-18 11:57:21 ~7 min ios 📦tgz
✔️ 4b10ab7 #2 2023-09-18 11:59:07 ~4 min android 📦tgz
✔️ 4b10ab7 #2 2023-09-18 12:00:44 ~10 min ios 📦tgz
✖️ cff75f6 #2 2023-09-18 13:19:41 ~21 sec tests 📄log
✔️ cff75f6 #2 2023-09-18 13:20:20 ~1 min linux 📦deb
✖️ cff75f6 #2 2023-09-18 13:20:42 ~1 min tests 📄log
✔️ cff75f6 #2 2023-09-18 13:21:09 ~1 min nix-flake 📄log
✔️ cff75f6 #3 2023-09-18 13:22:37 ~3 min android 📦tgz
✔️ cff75f6 #3 2023-09-18 13:23:16 ~4 min ios 📦tgz
✔️ 521bf64 #3 2023-09-18 13:37:11 ~1 min linux 📦deb
✔️ 521bf64 #3 2023-09-18 13:38:24 ~2 min nix-flake 📄log
✔️ 521bf64 #3 2023-09-18 13:39:06 ~2 min tests 📄log
✔️ 521bf64 #4 2023-09-18 13:39:23 ~3 min ios 📦tgz
✔️ 521bf64 #3 2023-09-18 13:39:24 ~3 min tests 📄log
✔️ 521bf64 #4 2023-09-18 13:40:18 ~4 min android 📦tgz
✔️ 320782c #4 2023-09-18 15:27:55 ~1 min nix-flake 📄log
✔️ 320782c #4 2023-09-18 15:28:12 ~2 min tests 📄log
✔️ 320782c #4 2023-09-18 15:28:26 ~2 min linux 📦deb
✔️ 320782c #4 2023-09-18 15:29:13 ~3 min tests 📄log
✔️ 320782c #5 2023-09-18 15:29:20 ~3 min android 📦tgz
✔️ 320782c #5 2023-09-18 15:37:06 ~11 min ios 📦tgz
✔️ b9f8a40 #5 2023-09-19 05:34:11 ~1 min linux 📦deb
✔️ b9f8a40 #5 2023-09-19 05:35:21 ~2 min nix-flake 📄log
✔️ b9f8a40 #5 2023-09-19 05:36:07 ~3 min tests 📄log
✔️ b9f8a40 #5 2023-09-19 05:36:13 ~3 min tests 📄log
✔️ b9f8a40 #6 2023-09-19 05:37:04 ~4 min android 📦tgz
✔️ b9f8a40 #6 2023-09-19 05:37:42 ~4 min ios 📦tgz
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 410ef15 #6 2023-09-19 05:36:03 ~1 min linux 📦deb
✔️ 410ef15 #6 2023-09-19 05:37:25 ~2 min nix-flake 📄log
✔️ 410ef15 #6 2023-09-19 05:37:39 ~1 min tests 📄log
✔️ 410ef15 #6 2023-09-19 05:38:02 ~1 min tests 📄log
✔️ 410ef15 #7 2023-09-19 05:38:52 ~3 min ios 📦tgz
✔️ 410ef15 #7 2023-09-19 05:40:21 ~3 min android 📦tgz
✔️ 403c8c5 #7 2023-09-19 05:54:06 ~1 min tests 📄log
✔️ 403c8c5 #7 2023-09-19 05:54:34 ~1 min tests 📄log
✔️ 403c8c5 #7 2023-09-19 05:54:38 ~1 min nix-flake 📄log
✔️ 403c8c5 #7 2023-09-19 05:55:03 ~2 min linux 📦deb
✔️ 403c8c5 #8 2023-09-19 05:55:50 ~3 min android 📦tgz
✔️ 403c8c5 #8 2023-09-19 05:56:15 ~3 min ios 📦tgz

@chaitanyaprem chaitanyaprem mentioned this pull request Sep 15, 2023
Closed
4 tasks
richard-ramos
richard-ramos approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool PR.

waku/v2/protocol/relay/waku_relay.go Outdated Show resolved Hide resolved
waku/v2/protocol/relay/waku_relay.go Outdated Show resolved Hide resolved
waku/v2/protocol/relay/waku_relay.go Outdated Show resolved Hide resolved
waku/v2/protocol/relay/waku_relay.go Outdated Show resolved Hide resolved
waku/v2/protocol/relay/waku_relay.go Outdated Show resolved Hide resolved
waku/v2/peermanager/peer_manager.go Outdated Show resolved Hide resolved
waku/v2/peermanager/peer_manager.go Outdated Show resolved Hide resolved
waku/v2/peermanager/peer_manager.go Outdated Show resolved Hide resolved
waku/v2/peermanager/peer_manager.go Outdated Show resolved Hide resolved
waku/v2/protocol/relay/waku_relay.go Outdated Show resolved Hide resolved
@harsh-98
Copy link
Contributor

lgtm.

@chaitanyaprem chaitanyaprem merged commit 9b05d48 into master Sep 19, 2023
2 checks passed
@chaitanyaprem chaitanyaprem deleted the feat/handle-peer-topic-sub-unsub branch September 19, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh-98 harsh-98 harsh-98 approved these changes

@richard-ramos richard-ramos richard-ramos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaitanyaprem @status-im-auto @harsh-98 @richard-ramos