Fix deleting pubsub topics; only allow adding unique topics #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvly
force-pushed
the
fix/peerstore-pubsubtopic-remove
branch
from
201e1b1 to
f5b80ed
Compare
Jenkins BuildsClick to see older builds (15)
|
vitvly
force-pushed
the
fix/peerstore-pubsubtopic-remove
branch
from
f5b80ed to
7803fa2
Compare
vitvly
force-pushed
the
fix/peerstore-pubsubtopic-remove
branch
from
7803fa2 to
a3d1203
Compare
vitvly
force-pushed
the
fix/peerstore-pubsubtopic-remove
branch
from
a3d1203 to
5983af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue introduced in #759
Context: #762 (comment)
EDIT: i see that it was independently fixed in #765
@chaitanyaprem can you please review this and decide if the uniqueness check is still worth it?