Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update relay REST and RPC API's and fix unit tests #866

Merged
merged 11 commits into from
Nov 7, 2023

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Nov 6, 2023

While updating relay REST API's to remove duplicate message cache as part of #861 , have noticed that REST and RPC unit tests are not run as part of CI and many of them are failing.

@harsh-98 did you not run and verify the Unit tests while working on #865 ?

Description

Changes

  • Update old relay REST API's to use new subscription
  • fix relay REST & RPC unit tests
  • fix RPC admin unit test
  • fix filter RPC and REST unit tests
  • Enable RPC and REST unit tests by default

Note: race condition failure should also be fixed by #867

Tests

@status-im-auto
Copy link

status-im-auto commented Nov 6, 2023

Jenkins Builds

Click to see older builds (30)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cb0abee #1 2023-11-06 14:03:27 ~1 min nix-flake 📄log
✔️ cb0abee #1 2023-11-06 14:03:51 ~2 min linux 📦deb
✖️ cb0abee #1 2023-11-06 14:03:51 ~2 min tests 📄log
✔️ cb0abee #1 2023-11-06 14:05:32 ~4 min tests 📄log
✔️ cb0abee #1 2023-11-06 14:05:46 ~4 min ios 📦tgz
✔️ cb0abee #1 2023-11-06 14:06:00 ~4 min android 📦tgz
✖️ 1008d17 #2 2023-11-07 06:45:13 ~36 sec tests 📄log
✔️ 1008d17 #2 2023-11-07 06:46:28 ~1 min nix-flake 📄log
✔️ 1008d17 #2 2023-11-07 06:46:59 ~2 min linux 📦deb
✔️ 1008d17 #2 2023-11-07 06:47:48 ~3 min android 📦tgz
✔️ 1008d17 #2 2023-11-07 06:47:53 ~3 min ios 📦tgz
✔️ 1008d17 #2 2023-11-07 06:47:56 ~3 min tests 📄log
✔️ 9463591 #3 2023-11-07 07:50:08 ~1 min linux 📦deb
✔️ 9463591 #3 2023-11-07 07:50:58 ~1 min nix-flake 📄log
✔️ 9463591 #3 2023-11-07 07:51:32 ~2 min tests 📄log
✔️ 9463591 #3 2023-11-07 07:52:21 ~3 min ios 📦tgz
✔️ 9463591 #3 2023-11-07 07:52:25 ~3 min android 📦tgz
✔️ 9463591 #3 2023-11-07 07:52:59 ~3 min tests 📄log
✔️ b154233 #4 2023-11-07 12:46:45 ~1 min linux 📦deb
✔️ b154233 #4 2023-11-07 12:47:29 ~1 min nix-flake 📄log
✔️ b154233 #4 2023-11-07 12:47:59 ~2 min tests 📄log
✔️ b154233 #4 2023-11-07 12:49:17 ~3 min android 📦tgz
✔️ b154233 #4 2023-11-07 12:49:41 ~4 min tests 📄log
✔️ b154233 #4 2023-11-07 12:51:11 ~5 min ios 📦tgz
✔️ 8fd4d0f #5 2023-11-07 12:48:54 ~2 min linux 📦deb
✔️ 8fd4d0f #5 2023-11-07 12:49:52 ~2 min nix-flake 📄log
✔️ 8fd4d0f #5 2023-11-07 12:51:59 ~3 min tests 📄log
✖️ 8fd4d0f #5 2023-11-07 12:52:50 ~3 min tests 📄log
✔️ 8fd4d0f #5 2023-11-07 12:53:10 ~3 min android 📦tgz
✔️ 8fd4d0f #5 2023-11-07 12:54:26 ~7 min ios 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ d0df695 #6 2023-11-07 12:52:30 ~23 sec tests 📄log
✔️ d0df695 #6 2023-11-07 12:52:53 ~1 min linux 📦deb
✖️ d0df695 #6 2023-11-07 12:53:14 ~20 sec tests 📄log
✔️ d0df695 #6 2023-11-07 12:53:33 ~1 min nix-flake 📄log
✔️ d0df695 #6 2023-11-07 12:55:50 ~4 min ios 📦tgz
✔️ d0df695 #6 2023-11-07 12:56:25 ~3 min android 📦tgz
✔️ bc71856 #7 2023-11-07 12:59:21 ~1 min tests 📄log
✔️ bc71856 #7 2023-11-07 12:59:41 ~2 min nix-flake 📄log
✔️ bc71856 #7 2023-11-07 12:59:59 ~2 min linux 📦deb
✔️ bc71856 #7 2023-11-07 13:00:26 ~3 min android 📦tgz
✔️ bc71856 #7 2023-11-07 13:01:14 ~3 min tests 📄log
✔️ bc71856 #7 2023-11-07 13:01:23 ~3 min ios 📦tgz

@chaitanyaprem chaitanyaprem changed the title chore: update relay REST and RPC API's chore: update relay REST and RPC API's and fix unit tests Nov 6, 2023
@chaitanyaprem chaitanyaprem removed the request for review from harsh-98 November 6, 2023 14:06
@chaitanyaprem chaitanyaprem marked this pull request as ready for review November 7, 2023 06:44
* chore: update relay RPC to not use local message cache

* chore: add unit tests for autosharding relay REST API, fix success response (#868)
@chaitanyaprem chaitanyaprem merged commit 2616d43 into master Nov 7, 2023
2 checks passed
@chaitanyaprem chaitanyaprem deleted the fix/relay-rest-unit-tests branch November 7, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants