Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : issues with get messages API #878

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Nov 8, 2023

Description

@fbarbu15 reported few issues he faced while testing RPC and REST API for relay with latest go-waku image.
These are fixes for some of the issues noticed.

Changes

  • Do not use request context in subscribe API as that would finish as soon as request is done which would close the subscription channel as well.
  • Add checks for channel open status and return error for RPC and REST APIs to avoid panic
  • Get Subscription API to not return subscription which has noConsume flag set(which indicates that this subscription is not created via an API rather only during node initialization)

Tests

@status-im-auto
Copy link

status-im-auto commented Nov 8, 2023

Jenkins Builds

Click to see older builds (13)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5a7c049 #1 2023-11-08 09:58:04 ~2 min nix-flake 📄log
✔️ 5a7c049 #1 2023-11-08 09:58:24 ~2 min linux 📦deb
✔️ 5a7c049 #1 2023-11-08 09:59:11 ~3 min tests 📄log
✔️ 5a7c049 #1 2023-11-08 09:59:39 ~3 min android 📦tgz
✔️ 5a7c049 #1 2023-11-08 09:59:46 ~3 min tests 📄log
✔️ 5a7c049 #1 2023-11-08 10:00:58 ~5 min ios 📦tgz
✔️ 8782b34 #3 2023-11-08 12:26:01 ~3 min ios 📦tgz
✔️ 8782b34 #2 2023-11-08 12:26:02 ~4 min ios 📦tgz
✔️ 8782b34 #2 2023-11-08 12:29:31 ~7 min linux 📦deb
✔️ 8782b34 #2 2023-11-08 12:30:58 ~9 min android 📦tgz
✔️ 8782b34 #2 2023-11-08 12:31:34 ~9 min nix-flake 📄log
✔️ 8782b34 #2 2023-11-08 12:31:51 ~10 min tests 📄log
✔️ 8782b34 #2 2023-11-08 12:33:28 ~11 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f722bbf #4 2023-11-08 12:29:38 ~3 min ios 📦tgz
✔️ f722bbf #3 2023-11-08 12:37:32 ~7 min linux 📦deb
✔️ f722bbf #3 2023-11-08 12:38:18 ~6 min nix-flake 📄log
✔️ f722bbf #3 2023-11-08 12:39:07 ~8 min android 📦tgz
✔️ f722bbf #3 2023-11-08 12:40:03 ~6 min tests 📄log
✔️ f722bbf #3 2023-11-08 12:41:29 ~9 min tests 📄log
✔️ cddaea8 #5 2023-11-08 12:58:47 ~3 min ios 📦tgz
✔️ cddaea8 #4 2023-11-08 13:08:10 ~13 min nix-flake 📄log
✔️ cddaea8 #4 2023-11-08 13:08:40 ~13 min linux 📦deb
✔️ cddaea8 #4 2023-11-08 13:09:50 ~14 min android 📦tgz
✔️ cddaea8 #4 2023-11-08 13:10:27 ~15 min tests 📄log
✔️ cddaea8 #4 2023-11-08 13:11:01 ~15 min tests 📄log

cmd/waku/server/rest/relay.go Dismissed Show dismissed Hide dismissed
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left few observations

cmd/waku/server/rpc/relay.go Outdated Show resolved Hide resolved
cmd/waku/server/rest/relay.go Outdated Show resolved Hide resolved
cmd/waku/server/rpc/relay.go Outdated Show resolved Hide resolved
@chaitanyaprem chaitanyaprem merged commit fab51be into master Nov 8, 2023
2 checks passed
@chaitanyaprem chaitanyaprem deleted the fix/rpc-rest-relay branch November 8, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants