Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WakuMessage json encoding #880

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Conversation

richard-ramos
Copy link
Member

Description

Fixes an issue reported by @fbarbu15 in which the waku message content topic field was not being decoded correctly in the REST API

@status-im-auto
Copy link

status-im-auto commented Nov 8, 2023

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ eb3b320 #1 2023-11-08 12:08:44 ~4 min ios 📦tgz
✔️ eb3b320 #1 2023-11-08 12:15:34 ~11 min android 📦tgz
✔️ eb3b320 #1 2023-11-08 12:15:54 ~11 min tests 📄log
✖️ eb3b320 #1 2023-11-08 12:16:07 ~12 min nix-flake 📄log
✔️ eb3b320 #1 2023-11-08 12:18:05 ~13 min linux 📦deb
✔️ eb3b320 #1 2023-11-08 12:19:29 ~15 min tests 📄log
✔️ 9012aa0 #2 2023-11-08 12:29:57 ~5 min ios 📦tgz
✔️ 9012aa0 #2 2023-11-08 12:33:24 ~8 min linux 📦deb
✔️ 9012aa0 #2 2023-11-08 12:33:59 ~9 min nix-flake 📄log
✔️ 9012aa0 #2 2023-11-08 12:34:09 ~9 min tests 📄log
✔️ 9012aa0 #2 2023-11-08 12:35:00 ~10 min android 📦tgz
✔️ 9012aa0 #2 2023-11-08 12:35:50 ~11 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 069a20a #3 2023-11-08 13:29:39 ~3 min ios 📦tgz
✔️ 069a20a #3 2023-11-08 13:31:28 ~5 min android 📦tgz
✔️ 069a20a #3 2023-11-08 13:31:29 ~5 min linux 📦deb
✔️ 069a20a #3 2023-11-08 13:31:41 ~5 min nix-flake 📄log
✔️ 069a20a #3 2023-11-08 13:33:05 ~7 min tests 📄log
✔️ 069a20a #3 2023-11-08 13:33:11 ~7 min tests 📄log
✔️ 0cb1673 #4 2023-11-08 16:05:06 ~1 min linux 📦deb
✔️ 0cb1673 #4 2023-11-08 16:05:50 ~1 min nix-flake 📄log
✔️ 0cb1673 #4 2023-11-08 16:06:40 ~2 min tests 📄log
✔️ 0cb1673 #4 2023-11-08 16:07:13 ~3 min android 📦tgz
✔️ 0cb1673 #4 2023-11-08 16:07:44 ~3 min tests 📄log
✔️ 0cb1673 #4 2023-11-08 16:07:59 ~4 min ios 📦tgz

Copy link

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@richard-ramos richard-ramos force-pushed the fix/wakumsg/json-encoding branch from eb3b320 to 9012aa0 Compare November 8, 2023 12:24
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit 3d217ed into master Nov 8, 2023
3 checks passed
@richard-ramos richard-ramos deleted the fix/wakumsg/json-encoding branch November 8, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants