fix: Execution logic for default topic validators in WakuRelay #887
Conversation
hishboy
changed the title
|
Good catch! |
Hey @chaitanyaprem, yep we're building tribes decentralized network using go-waku and js-waku (https://www.tribes.xyz) |
Did not know that, Awesome! Specifically how are you guys using go-waku and js-waku? Do reach out to us on discord in case you require any support or discussion. |
|
@chaitanyaprem yep I'm in the discord. Username |
|
Hey @richard-ramos / @chaitanyaprem, it seems like the checks are stuck for a while (see screenshot). Is it common to take that long to complete? 
|
Nah, they are generally done in max of 10 mins. |
Jenkins Builds
|
Description
This PR addresses an issue in the WakuRelay's topic validation mechanism. Previously, if topicValidators were not set for a specific topic but defaultTopicValidators were provided, the logic incorrectly bypassed executing these default validators. This was due to the check being performed before merging the defaultTopicValidators. The proposed change ensures we correctly assess the combined list of validators after merging both topicValidators and defaultTopicValidators. This means that all validators will always be considered, regardless of whether specific topic validators are set.