Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not start metadata protocol unless required #920

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Nov 22, 2023

Changes

  • Metadata protocol is not started unless clusterId is specified
  • Simplifies peer disconnection logic, if an error is returned when doing a metadata request or if there is a clusterID mismatch

@status-im-auto
Copy link

status-im-auto commented Nov 22, 2023

Jenkins Builds

Click to see older builds (20)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cf8a8a7 #1 2023-11-22 18:28:12 ~2 min nix-flake 📄log
✖️ cf8a8a7 #1 2023-11-22 18:29:08 ~3 min tests 📄log
✔️ cf8a8a7 #1 2023-11-22 18:30:08 ~4 min android 📦tgz
✔️ cf8a8a7 #1 2023-11-22 18:30:35 ~4 min ios 📦tgz
✖️ cf8a8a7 #1 2023-11-22 18:30:39 ~4 min tests 📄log
✔️ cf8a8a7 #1 2023-11-22 18:35:25 ~9 min linux 📦deb
✔️ ee2e41a #2 2023-11-22 18:35:55 ~2 min nix-flake 📄log
✔️ 35c5e80 #3 2023-11-22 19:58:35 ~2 min nix-flake 📄log
✔️ 35c5e80 #2 2023-11-22 19:58:57 ~2 min linux 📦deb
✔️ 35c5e80 #2 2023-11-22 19:59:34 ~2 min tests 📄log
✔️ 35c5e80 #2 2023-11-22 20:00:27 ~3 min ios 📦tgz
✔️ 35c5e80 #2 2023-11-22 20:00:59 ~4 min tests 📄log
✔️ 35c5e80 #2 2023-11-22 20:06:52 ~10 min android 📦tgz
✔️ 4df40c3 #3 2023-11-23 22:19:55 ~1 min linux 📦deb
✔️ 4df40c3 #3 2023-11-23 22:20:11 ~1 min tests 📄log
✔️ 4df40c3 #4 2023-11-23 22:20:34 ~1 min nix-flake 📄log
✔️ 4df40c3 #3 2023-11-23 22:22:29 ~3 min tests 📄log
✔️ 4df40c3 #3 2023-11-23 22:22:59 ~4 min ios 📦tgz
✔️ 4df40c3 #3 2023-11-23 22:29:08 ~10 min android 📦tgz
✔️ 1df120a #5 2023-11-23 22:25:46 ~1 min nix-flake 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4b3ba29 #6 2023-11-27 00:46:21 ~4 min nix-flake 📄log
✔️ e373182 #7 2023-11-28 14:08:13 ~2 min nix-flake 📄log

waku/v2/protocol/metadata/waku_metadata.go Outdated Show resolved Hide resolved
waku/v2/protocol/metadata/waku_metadata.go Outdated Show resolved Hide resolved
waku/v2/protocol/metadata/waku_metadata.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left few comments.

waku/v2/protocol/metadata/waku_metadata.go Outdated Show resolved Hide resolved
waku/v2/protocol/metadata/waku_metadata.go Show resolved Hide resolved
waku/v2/protocol/metadata/waku_metadata.go Show resolved Hide resolved
Copy link
Contributor

@kaichaosun kaichaosun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit cf8c36f into master Nov 28, 2023
12 checks passed
@richard-ramos richard-ramos deleted the metadata-skip branch November 28, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants