Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker Secret support #248

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Docker Secret support #248

wants to merge 3 commits into from

Conversation

abelfodil
Copy link

No description provided.

j0k3r
j0k3r reviewed Jan 21, 2021
View reviewed changes
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, any chance to add a new test to cover that behavior?

@abelfodil abelfodil force-pushed the master branch 2 times, most recently from 0f036fd to 5efaf08 Compare January 21, 2021 15:49
@abelfodil
Copy link
Author

done

@j0k3r j0k3r requested a review from Kdecherf January 21, 2021 16:28
@j0k3r j0k3r mentioned this pull request Feb 17, 2021
Open
@deafmute1
Copy link

@Kdecherf any chance of getting this merged?

@Kdecherf
Copy link
Member

Kdecherf commented May 6, 2021

@deafmute1 I'll try to review this PR in the coming weeks

@DennisGaida
Copy link

Any update on this? This was a good PR and necessary to support docker secrets.

@P1nk-P0nk
Copy link

Is there a way to help review/merge this ?
I would really like to use secrets in my setup.

@adamantike
Copy link

@j0k3r @Kdecherf, gentle ping to get this reviewed. It would be great to have support for Docker secrets!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r left review comments

@Kdecherf Kdecherf Awaiting requested review from Kdecherf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abelfodil @deafmute1 @Kdecherf @DennisGaida @P1nk-P0nk @adamantike @j0k3r