Merge branch 'StarRocks:main' into thirdparty

.clang-format

@@ -13,7 +13,6 @@ PointerAlignment: Left
 ReflowComments: false
 SortUsingDeclarations: false
 SpacesBeforeTrailingComments: 1
-AllowShortFunctionsOnASingleLine: Inline
 ---
 Language: Java
 BasedOnStyle: Google
@@ -29,3 +28,6 @@ PointerAlignment: Left
 ReflowComments: false
 SortUsingDeclarations: false
 SpacesBeforeTrailingComments: 1
+---
+Language: Proto
+BasedOnStyle: Google

.clang-tidy

@@ -2,11 +2,9 @@
 Checks: >
     -*,
     cppcoreguidelines-virtual-class-destructor,
-    modernize-avoid-bind,
     modernize-concat-nested-namespaces,
     modernize-deprecated-headers,
     modernize-deprecated-ios-base-aliases,
-    modernize-loop-convert,
     modernize-make-shared,
     modernize-make-unique,
     modernize-pass-by-value,
@@ -15,10 +13,9 @@ Checks: >
     modernize-replace-auto-ptr,
     modernize-replace-disallow-copy-and-assign-macro,
     modernize-replace-random-shuffle,
-    modernize-return-braced-init-list,
+    -modernize-return-braced-init-list,
     modernize-shrink-to-fit,
     modernize-unary-static-assert,
-    modernize-use-auto,
     modernize-use-bool-literals,
     modernize-use-default-member-init,
     modernize-use-emplace,
@@ -40,3 +37,5 @@ Checks: >
     performance-type-promotion-in-math-fn,
     performance-unnecessary-copy-initialization,
     performance-unnecessary-value-param,
+
+WarningsAsErrors: '*'

.dockerignore

@@ -5,23 +5,18 @@
 be/build_
 thirdparty/installed
 thirdparty/src
-
 **/target
 **/log
-
 **/.github
 **/.idea
-
 **/*.o
-
 **/output
 # negate the output as it might be used for packing container from locally build artifact
 !output
 output/fe/meta
 output/fe/log
 output/be/storage
 output/be/log
-
-
-
-
+# allow build fs_broker into allin1 docker image
+!fs_brokers/apache_hdfs_broker/output
+fs_brokers/apache_hdfs_broker/output/log

.github/CODEOWNERS

@@ -1,5 +1,136 @@
 # committer will be the owner of all codes
 *   @StarRocks/starrocks-committer
 
+# cpp miscellaneous
+/be/src/common/     @StarRocks/cpp-misc-maintainer
+/be/src/gen_cpp/    @StarRocks/cpp-misc-maintainer
+/be/src/gutil/      @StarRocks/cpp-misc-maintainer
+/be/src/simd/       @StarRocks/cpp-misc-maintainer
+/be/src/testutil/   @StarRocks/cpp-misc-maintainer
+/be/src/util/       @StarRocks/cpp-misc-maintainer
+
+# execution engine 
+/be/src/column/  @StarRocks/execution-maintainer
+/be/src/exec/    @StarRocks/execution-maintainer
+/be/src/exprs/   @StarRocks/execution-maintainer
+/be/src/runtime/ @StarRocks/execution-maintainer
+/be/src/types/   @StarRocks/execution-maintainer
+/be/src/udf/     @StarRocks/execution-maintainer
+
+# open formats
+/be/src/formats/  @StarRocks/open-format-maintainer
+
+# storage engine 
+/be/src/fs/       @StarRocks/storage-maintainer
+/be/src/io/       @StarRocks/storage-maintainer
+/be/src/storage/  @StarRocks/storage-maintainer
+
 # /docs/ belong to docs-maintainer
 /docs/  @StarRocks/docs-maintainer
+
+# /docker
+/docker/  @StarRocks/docker-maintainer
+
+# metadata
+/fe/fe-core/src/main/java/com/starrocks/authentication/             @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/privilege/                  @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/     @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/mysql/                      @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/transaction/                @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/healthchecker/              @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/clone/                      @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/consistency/                @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/ha/                         @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/journal/    @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/leader/     @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/meta/       @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/persist/    @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/alter/      @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/backup/     @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/catalog/    @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/metric/     @StarRocks/metadata-maintainer
+/fe/fe-core/src/main/java/com/starrocks/system/     @StarRocks/metadata-maintainer
+
+# connector
+/fe/fe-core/src/main/java/com/starrocks/connector/  @StarRocks/connector-maintainer
+/fe/fe-core/src/main/java/com/starrocks/credential/  @StarRocks/connector-maintainer
+
+# parser
+/fe/fe-core/src/main/java/com/starrocks/sql/ast/ @StarRocks/parser
+/fe/fe-core/src/main/java/com/starrocks/sql/parser/ @StarRocks/parser
+
+# analyzer
+/fe/fe-core/src/main/java/com/starrocks/sql/analyzer/ @StarRocks/analyzer
+/fe/fe-core/src/main/java/com/starrocks/analysis/ @StarRocks/analyzer
+
+# optimizer
+/fe/fe-core/src/main/java/com/starrocks/sql/optimizer/ @StarRocks/optimizer
+/fe/fe-core/src/main/java/com/starrocks/statistic/ @StarRocks/optimizer
+
+# scheduler
+/fe/fe-core/src/main/java/com/starrocks/qe/scheduler/ @StarRocks/scheduler-maintainer
+
+# sql/parser/StarRocksLex.g4 sql/parser/StarRocks.g4 belong to syntax-committer
+/fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocksLex.g4  @StarRocks/syntax-committer
+/fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocks.g4  @StarRocks/syntax-committer
+/gensrc/script/functions.py  @StarRocks/syntax-committer
+
+# /thirdparty/ /docker/dockerfiles/dev-env/dev-env.Dockerfile belong to thirdparty-maintainer
+/be/src/thirdparty/  @StarRocks/thirdparty-maintainer
+/thirdparty/  @StarRocks/thirdparty-maintainer
+/docker/dockerfiles/dev-env/dev-env.Dockerfile   @StarRocks/thirdparty-maintainer
+
+# cloud native
+/be/src/storage/lake/ @StarRocks/cloud-native-maintainer
+/be/src/runtime/lake_tablets_channel.h @StarRocks/cloud-native-maintainer
+/be/src/runtime/lake_tablets_channel.cpp @StarRocks/cloud-native-maintainer
+
+# error message
+/fe/fe-core/src/main/java/com/starrocks/common/ErrorCode.java  @StarRocks/msg-reviewer
+
+# StorageEngine/ExecEnv/GlobalEnv
+/be/src/runtime/exec_env.h @StarRocks/thread-committer
+/be/src/runtime/exec_env.cpp @StarRocks/thread-committer
+/be/src/storage/olap_server.cpp @StarRocks/thread-committer
+/be/src/storage/storage_engine.h @StarRocks/thread-committer
+/be/src/storage/storage_engine.cpp @StarRocks/thread-committer
+/be/src/service/starrocks_main.cpp @StarRocks/thread-committer
+/be/src/service/service_be/starrocks_be.cpp @StarRocks/thread-committer
+
+# restful
+/fe/fe-core/src/main/java/com/starrocks/http @StarRocks/restful-maintainer
+/be/src/http @StarRocks/restful-maintainer
+
+
+# load and unload
+/fe/fe-core/src/main/java/com/starrocks/load/*                  @StarRocks/load-unload-maintainer
+/fe/fe-core/src/main/java/com/starrocks/plan/StreamLoad*        @StarRocks/load-unload-maintainer
+/fe/fe-core/src/main/java/com/starrocks/plan/*Sink.java         @StarRocks/load-unload-maintainer
+/fe/fe-core/src/main/java/com/starrocks/sql/InsertPlanner.java  @StarRocks/load-unload-maintainer
+/fe/fe-core/src/main/java/com/starrocks/sql/LoadPlanner.java    @StarRocks/load-unload-maintainer
+/fe/fe-core/src/main/java/com/starrocks/backup/*                @StarRocks/load-unload-maintainer
+/fe/fe-core/src/main/java/com/starrocks/alter/Optimize*         @StarRocks/load-unload-maintainer
+/fe/fe-core/src/main/java/com/starrocks/alter/Compaction*       @StarRocks/load-unload-maintainer
+/fe/fe-core/src/main/java/com/starrocks/catalog/*Partition*     @StarRocks/load-unload-maintainer
+
+/be/src/storage/*                                       @StarRocks/load-unload-maintainer
+/be/src/exec/tablet_sink*                               @StarRocks/load-unload-maintainer
+/be/src/exec/csv_scanner.cpp                            @StarRocks/load-unload-maintainer
+/be/src/exec/json_scanner.cpp                           @StarRocks/load-unload-maintainer
+/be/src/exec/pipeline/olap_table_sink_operator.cpp      @StarRocks/load-unload-maintainer
+/be/src/formats/avro/*                          @StarRocks/load-unload-maintainer
+/be/src/formats/csv/*                           @StarRocks/load-unload-maintainer
+/be/src/formats/json/*                          @StarRocks/load-unload-maintainer
+/be/src/http/action/compaction_action.cpp       @StarRocks/load-unload-maintainer
+/be/src/http/action/*stream_load.cpp    @StarRocks/load-unload-maintainer
+/be/src/http/action/restore*            @StarRocks/load-unload-maintainer
+/be/src/runtime/routine_load/*          @StarRocks/load-unload-maintainer
+/be/src/runtime/stream_load/*           @StarRocks/load-unload-maintainer
+/be/src/runtime/load*                   @StarRocks/load-unload-maintainer
+/be/src/runtime/tablets_channel.cpp     @StarRocks/load-unload-maintainer
+/be/src/runtime/export_sink.cpp         @StarRocks/load-unload-maintainer
+
+# meta upgrade/downgrade compatibility
+/fe/fe-core/src/main/java/com/starrocks/persist/gson/GsonUtils.java @StarRocks/meta-compatibility-maintainer
+
+

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,5 @@
+blank_issues_enabled: false
+contact_links:
+  - name: Need help or have a question?
+    url: https://join.slack.com/t/starrocks/shared_invite/zt-z5zxqr0k-U5lrTVlgypRIV8RbnCIAzg
+    about: Visit our slack channel.

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,4 +1,11 @@
-## What type of PR is this：
+## Why I'm doing:
+
+## What I'm doing:
+
+Fixes #issue
+
+## What type of PR is this:
+
 - [ ] BugFix
 - [ ] Feature
 - [ ] Enhancement
@@ -7,26 +14,30 @@
 - [ ] Doc
 - [ ] Tool
 
-## Which issues of this PR fixes ：
-<!--
-Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
--->
-Fixes #
+Does this PR entail a change in behavior?
+
+- [x] Yes, this PR will result in a change in behavior.
+- [ ] No, this PR will not result in a change in behavior.
+
+If yes, please specify the type of change:
 
-## Problem Summary(Required) ：
-<!-- (Please describe the changes you have made. In which scenarios will this bug be triggered and what measures have you taken to fix the bug?) -->
+- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
+- [ ] Parameter changes: default values, similar parameters but with different default values
+- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
+- [ ] Feature removed
+- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
 
 ## Checklist:
 
 - [ ] I have added test cases for my bug fix or my new feature
-- [ ] This pr will affect users' behaviors
 - [ ] This pr needs user documentation (for new or modified features or behaviors)
   - [ ] I have added documentation for my new feature or new function
+- [ ] This is a backport pr
 
 ## Bugfix cherry-pick branch check:
-- [ ] I have checked the version labels which the pr will be auto backported to target branch
-  - [ ] 3.0
-  - [ ] 2.5
-  - [ ] 2.4
-  - [ ] 2.3
+- [ ] I have checked the version labels which the pr will be auto-backported to the target branch
+  - [ ] 3.4
+  - [ ] 3.3
+  - [ ] 3.2
+  - [ ] 3.1
+  - [ ] 3.0

.github/workflows/approve-checker.yml

@@ -0,0 +1,95 @@
+name: REVIEW CHECKER
+
+on:
+
+  pull_request_review:
+    types:
+      - submitted
+
+permissions:
+  checks: write
+  actions: write
+  contents: write
+  deployments: write
+  discussions: write
+  issues: write
+  packages: write
+  pages: write
+  pull-requests: write
+  repository-projects: write
+  security-events: write
+  statuses: write
+
+jobs:
+
+  info:
+    if: >
+      (github.event.pull_request && github.event.requested_team) ||
+      (github.event.pull_request.requested_teams && github.event.review && github.event.review.state == 'approved')
+    runs-on: ubuntu-latest
+    env:
+      REPO: ${{ github.repository }}
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+    outputs:
+      LABELS: ${{ steps.label_info.outputs.labels }}
+      PR_NUMBER: ${{ steps.pr.outputs.PR_NUMBER }}
+      HEAD_REF: ${{ steps.pr.outputs.HEAD_REF }}
+
+    steps:
+      - name: PR
+        id: pr
+        run: |
+          if [[ "${{ github.event.number }}" != "" ]]; then
+            echo "PR_NUMBER=${{ github.event.number }}" >> $GITHUB_OUTPUT
+          else
+            echo "PR_NUMBER=${{ github.event.pull_request.number }}" >> $GITHUB_OUTPUT
+            echo "HEAD_REF=${{ github.event.pull_request.head.ref }}" >> $GITHUB_OUTPUT
+          fi
+
+      - name: LABELS
+        id: label_info
+        env:
+          PR_NUMBER: ${{ steps.pr.outputs.PR_NUMBER }}
+        run: |
+          labels=$(gh pr view ${PR_NUMBER} -R ${REPO} --json labels -q '.labels[].name')
+          echo "labels<<EOF" >> $GITHUB_OUTPUT
+          echo "$labels" >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
+          
+          cat $GITHUB_OUTPUT
+
+  meta-review:
+    needs: info
+    runs-on: [ self-hosted, normal ]
+    if: github.event_name == 'pull_request_review' && contains(needs.info.outputs.LABELS, 'META-REVIEW') && !contains(needs.info.outputs.LABELS, 'sync') && !startsWith(needs.info.outputs.HEAD_REF, 'mergify/')
+    name: META-REVIEW
+
+    env:
+      PR_NUMBER: ${{ needs.info.outputs.PR_NUMBER }}
+      REPO: ${{ github.repository }}
+      TEAM: meta-committer
+      GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+    steps:
+      - name: META-REVIEW
+        run: |
+          rm -rf ./ci-tool && cp -rf /var/lib/ci-tool ./ci-tool && cd ci-tool && git pull >/dev/null
+          ./scripts/check-approve.sh
+
+  proto-review:
+    needs: info
+    runs-on: [ self-hosted, normal ]
+    if: github.event_name == 'pull_request_review' && contains(needs.info.outputs.LABELS, 'PROTO-REVIEW') && !contains(needs.info.outputs.LABELS, 'sync') && !startsWith(needs.info.outputs.HEAD_REF, 'mergify/')
+    name: PROTO-REVIEW
+
+    env:
+      PR_NUMBER: ${{ needs.info.outputs.PR_NUMBER }}
+      REPO: ${{ github.repository }}
+      TEAM: proto-team
+      GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+    steps:
+      - name: PROTO-REVIEW
+        run: |
+          rm -rf ./ci-tool && cp -rf /var/lib/ci-tool ./ci-tool && cd ci-tool && git pull >/dev/null
+          ./scripts/check-approve.sh