Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(eslint-plugin): Fix option schema #1139

Merged
merged 2 commits into from
Sep 27, 2024
Merged

hotfix(eslint-plugin): Fix option schema #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afe9eee
hotfix(eslint-plugin): Fix option schema
chloe463 Sep 27, 2024
b06c9fa
chore: Add changeset
chloe463 Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/dull-terms-matter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"eslint-plugin-use-macros": patch
"eslint-plugin-wantedly": patch
---

hotfix(eslint-plugin): Fix option schema
2 changes: 0 additions & 2 deletions packages/eslint-plugin-use-macros/__tests__/GraphQLTag.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,13 @@ ruleTester.run("use-macros/graphql-tag", GraphQLTagRule, {
valid: [
{
code: `import { gql } from "graphql.macro";`,
options: ["error"],
},
],
invalid: [
{
code: `import gql from "graphql-tag";`,
output: `import { gql } from "graphql.macro";`,
errors: ['Please import from "graphql.macro" instead of "graphql-tag"'],
options: ["error"],
},
],
});
2 changes: 0 additions & 2 deletions packages/eslint-plugin-use-macros/__tests__/StyledComponents.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,13 @@ ruleTester.run("use-macros/styled-components", StyledComponentsRule, {
valid: [
{
code: `import styled from "styled-components/macro";`,
options: ["error"],
},
],
invalid: [
{
code: `import styled from "styled-components";`,
output: `import styled from "styled-components/macro";`,
errors: ['Please import from "styled-components/macro" instead of "styled-components"'],
options: ["error"],
},
],
});
5 changes: 0 additions & 5 deletions packages/eslint-plugin-use-macros/rules/GraphQLTag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ module.exports = {
meta: {
type: "suggestion",
fixable: "code",
schema: [
{
enum: ["error", "warn", "off"],
},
],
},
create(context) {
return {
Expand Down
5 changes: 0 additions & 5 deletions packages/eslint-plugin-use-macros/rules/StyledComponents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ module.exports = {
meta: {
type: "suggestion",
fixable: "code",
schema: [
{
enum: ["error", "warn", "off"],
},
],
},
create(context) {
return {
Expand Down
124 changes: 0 additions & 124 deletions packages/eslint-plugin-wantedly/src/__tests__/__snapshots__/index.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@ exports[`should match snapshot 1`] = `
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
{
"additionalProperties": false,
"properties": {
Expand All @@ -43,13 +36,6 @@ exports[`should match snapshot 1`] = `
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
{
"additionalProperties": false,
"properties": {
Expand All @@ -71,13 +57,6 @@ exports[`should match snapshot 1`] = `
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
{
"additionalProperties": false,
"properties": {
Expand All @@ -98,15 +77,6 @@ exports[`should match snapshot 1`] = `
"url": "https://github.com/wantedly/frolint/tree/master/packages/eslint-plugin-wantedly/docs/rules/nexus-enum-values-description.md",
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
],
"type": "suggestion",
},
},
Expand All @@ -117,15 +87,6 @@ exports[`should match snapshot 1`] = `
"url": "https://github.com/wantedly/frolint/tree/master/packages/eslint-plugin-wantedly/docs/rules/nexus-field-description.md",
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
],
"type": "suggestion",
},
},
Expand All @@ -137,13 +98,6 @@ exports[`should match snapshot 1`] = `
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
{
"additionalProperties": false,
"properties": {
Expand All @@ -163,15 +117,6 @@ exports[`should match snapshot 1`] = `
"docs": {
"url": "https://github.com/wantedly/frolint/tree/master/packages/eslint-plugin-wantedly/docs/rules/nexus-type-description.md",
},
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
],
"type": "suggestion",
},
},
Expand All @@ -183,13 +128,6 @@ exports[`should match snapshot 1`] = `
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
{
"additionalProperties": false,
"properties": {
Expand Down Expand Up @@ -217,13 +155,6 @@ exports[`should match snapshot 1`] = `
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
{
"additionalProperties": false,
"properties": {
Expand All @@ -245,13 +176,6 @@ exports[`should match snapshot 1`] = `
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
{
"additionalProperties": false,
"properties": {
Expand All @@ -273,13 +197,6 @@ exports[`should match snapshot 1`] = `
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
{
"additionalProperties": false,
"properties": {
Expand All @@ -300,15 +217,6 @@ exports[`should match snapshot 1`] = `
"url": "https://github.com/wantedly/frolint/tree/master/packages/eslint-plugin-wantedly/docs/rules/nexus-enum-values-description.md",
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
],
"type": "suggestion",
},
},
Expand All @@ -319,15 +227,6 @@ exports[`should match snapshot 1`] = `
"url": "https://github.com/wantedly/frolint/tree/master/packages/eslint-plugin-wantedly/docs/rules/nexus-field-description.md",
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
],
"type": "suggestion",
},
},
Expand All @@ -339,13 +238,6 @@ exports[`should match snapshot 1`] = `
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
{
"additionalProperties": false,
"properties": {
Expand All @@ -365,15 +257,6 @@ exports[`should match snapshot 1`] = `
"docs": {
"url": "https://github.com/wantedly/frolint/tree/master/packages/eslint-plugin-wantedly/docs/rules/nexus-type-description.md",
},
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
],
"type": "suggestion",
},
},
Expand All @@ -385,13 +268,6 @@ exports[`should match snapshot 1`] = `
},
"fixable": "code",
"schema": [
{
"enum": [
"error",
"warn",
"off",
],
},
{
"additionalProperties": false,
"properties": {
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-wantedly/src/rules/__tests__/graphql-operation-name.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ gql\`
}
\`;`,
errors: ["The operation name getProject should be PascalCase"],
options: ["error", { autofix: true }],
options: [{ autofix: true }],
},
{
name: "No operation name is specified for a query",
Expand Down
10 changes: 5 additions & 5 deletions packages/eslint-plugin-wantedly/src/rules/__tests__/graphql-pascal-case-type-name.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ ruleTester.run(RULE_NAME, RULE, {
}
\`;`,
errors: ["The interface type node should be PascalCase"],
options: ["error", { autofix: true }],
options: [{ autofix: true }],
},
{
name: "Type name is fixed by plugin",
Expand All @@ -100,7 +100,7 @@ ruleTester.run(RULE_NAME, RULE, {
}
\`;`,
errors: ["The object type foo should be PascalCase"],
options: ["error", { autofix: true }],
options: [{ autofix: true }],
},
{
name: "Fragment name is fixed by plugin",
Expand All @@ -115,7 +115,7 @@ ruleTester.run(RULE_NAME, RULE, {
}
\`;`,
errors: ["The fragment fooFragment should be PascalCase"],
options: ["error", { autofix: true }],
options: [{ autofix: true }],
},
{
name: "Nested fragment name is fixed by plugin",
Expand All @@ -132,7 +132,7 @@ ruleTester.run(RULE_NAME, RULE, {
\$\{BarFragment\}
\`;`,
errors: ["The fragment fooFragment should be PascalCase"],
options: ["error", { autofix: true }],
options: [{ autofix: true }],
},
{
name: "Nested fragment name is fixed by plugin 2",
Expand All @@ -149,7 +149,7 @@ ruleTester.run(RULE_NAME, RULE, {
}
\`;`,
errors: ["The fragment fooFragment should be PascalCase"],
options: ["error", { autofix: true }],
options: [{ autofix: true }],
},
],
});
3 changes: 1 addition & 2 deletions packages/eslint-plugin-wantedly/src/rules/__tests__/nexus-camel-case-field-name.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ const User = objectType({
"The field Profile should be camelCase",
"The field Posts should be camelCase",
],
options: ["error"],
},
{
name: "Auto fix enabled",
Expand Down Expand Up @@ -78,7 +77,7 @@ const User = objectType({
"The field Profile should be camelCase",
"The field Posts should be camelCase",
],
options: ["error", { autofix: true }],
options: [{ autofix: true }],
},
],
});
Loading
Loading