Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactor rule sets #1141

Merged
merged 10 commits into from
Dec 5, 2024
Merged

refactor: Refactor rule sets #1141

merged 10 commits into from
Dec 5, 2024

Conversation

chloe463
Copy link
Contributor

@chloe463 chloe463 commented Nov 28, 2024 •
edited
Loading

  • Add import/order rules
  • Update eslint-plugin-react and eslint-plugin-react-hooks. (By updating these, we don't need eslint/compat anymore 🎉 )

@github-actions github-actions bot added repo Root directory of this project eslint-config-wantedly-typescript https://www.npmjs.com/package/eslint-config-wantedly-typescript eslint-config-wantedly https://www.npmjs.com/package/eslint-config-wantedly labels Nov 28, 2024
@chloe463 chloe463 changed the title fix: Fix import order rules reafactor: Refactor rule sets Nov 29, 2024
@chloe463 chloe463 marked this pull request as ready for review December 4, 2024 10:14
@chloe463 chloe463 requested a review from a team December 4, 2024 10:15
@chloe463 chloe463 changed the title reafactor: Refactor rule sets refactor: Refactor rule sets Dec 4, 2024
torabit
torabit approved these changes Dec 4, 2024
View reviewed changes
Copy link

@torabit torabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloe463
Copy link
Contributor Author

chloe463 commented Dec 5, 2024

Thank you

@chloe463 chloe463 merged commit a79246f into master Dec 5, 2024
4 checks passed
@chloe463 chloe463 deleted the chloe463/refactor/config branch December 5, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torabit torabit torabit approved these changes

Assignees
No one assigned
Labels
eslint-config-wantedly https://www.npmjs.com/package/eslint-config-wantedly eslint-config-wantedly-typescript https://www.npmjs.com/package/eslint-config-wantedly-typescript repo Root directory of this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chloe463 @torabit