Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in example (miss-leading under certain circumstance) #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jianxiongcai
Copy link

@jianxiongcai jianxiongcai commented Mar 13, 2019

Description

There is a potential bug in the given example, regarding the regular expression for file matching. This could lead to mismatching between image filenames and annotation filenames, which may cause serious confusion in the final COCO-format result.

Details

file_name_prefix = basename_no_extension + '.*'

The line above produces a regular expression for file matching image file with its annotation files. However, it might fail under certain circumstances.

For example, if there are two images (1.jpg and 1000.jpg). The regular expression produced when finding the annotation files for 1.jpg will be 1.*. Unfortunately, this expression also includes annotation files corresponding to 1000.png

Implemented fix

Changed the regular expression from basename.* to baseline_.* successfully solved the problem, as long as the user sticks to the naming convention basename_classname_instanceID for annotation files.

Note

this bug does not affect the original example, but users modifying the example for their custom dataset may trigger it and suffer from that. At least, it took me considerable time to figure that out. :)

There is a potential bug in the given example, regarding the regular expression for file matching.
@jianxiongcai jianxiongcai changed the title Fix miss-leading example Fix bug in example (miss-leading bugs may occurs under certain circumstance) Mar 13, 2019
@jianxiongcai jianxiongcai changed the title Fix bug in example (miss-leading bugs may occurs under certain circumstance) Fix bug in example (miss-leading bugs under certain circumstance) Mar 13, 2019
@jianxiongcai jianxiongcai changed the title Fix bug in example (miss-leading bugs under certain circumstance) Fix bug in example (miss-leading under certain circumstance) Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant