Possibility to select year only #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have to see how this looks. Based on the code I'm not sure You could also just use a dropdown ;-) |
wdullaer
reviewed
Sep 14, 2016
| @@ -295,6 +299,11 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, | |||
| mCancelString = savedInstanceState.getString(KEY_CANCEL_STRING); | |||
| } | |||
|
|
|||
| if (mShowYearOnly) { | |||
There was a problem hiding this comment.
Rather than removing these views, set their visibility to GONE.
This avoids potential NullPointerExceptions when other pieces of the code try to fetch them
| @@ -576,6 +585,13 @@ public void showYearPickerFirst(boolean yearPicker) { | |||
| mDefaultView = yearPicker ? YEAR_VIEW : MONTH_AND_DAY_VIEW; | |||
| } | |||
|
|
|||
| public void showYearOnly(boolean yearOnly) { | |||
| mShowYearOnly = yearOnly; | |||
| if (yearOnly) { | |||
There was a problem hiding this comment.
This will fail if someone later set showYearPickerFirst to false
You'll have to change the setter for showYearPickerFirst too
mShowYearFirst = yearOnly || showYearFirst;You'll also have to add some logic to the sample app that takes this paired logic into account. (would be great if android had some nice way to do reactive UIs, but there you go)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a case where I only need to track user's birthyear, so month and day controls are not useful to me. I made it possible to only display the year picker view.