fix invalid urlpattern test(s) #49782
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
|
cc @sisidovski |
|
Aside: are there no tests where port is assigned to something that is clearly not a port? |
anonrig
force-pushed
the
anonrig/fix-wpt-for-urlpattern
branch
3 times, most recently
from
d66cd3c to
1e055be
Compare
@annevk I'm not sure. By the way, port is not the only wrong test here. As I progress with Ada's implementation, it seems |
anonrig
force-pushed
the
anonrig/fix-wpt-for-urlpattern
branch
from
1e055be to
68ffecf
Compare
anonrig
force-pushed
the
anonrig/fix-wpt-for-urlpattern
branch
from
68ffecf to
153c3e9
Compare
|
@annevk I've added a new commit that includes a test for a failing port field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes whatwg/urlpattern#239
Port calls canonicalizePort which just calls url parser setter, which removes the leading trailing c0 whitespace characters from the input.
cc @annevk @lucacasonato @sisidovski