Fix for Breaking S3 Changes #4129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? |
riipeckx
approved these changes
Oct 24, 2024
|
Unfortunately this is not the end of issues from #4030 for me at least. The zoom tile generation thread gets stuck in an infinite loop trying to read from s3, and silently failing without any message. This process generates about 2-3MB/s of constant traffic to s3 while not successfully writing zoom tiles. I wonder if you're having the same issue? Putting a breakpoint in processZoomFile reveals that the call to S3Client.getObjectAsBytes is failing. |
|
@stewi1014 My server have been running for ~6hours for now and still rendering and uploading zoom tiles (not using AWS S3, I'm uploading to Cloudflare R2). As I'm not a Java developer at all I can't ensure I will not be facing an issue soon. Keep us updated :) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undoing some changes made in #4030 that broke support for S3 (see #4128). These changes will now make sure the appropriate section of the buffer is written to the S3 bucket. Hence resolving #4128.