Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uncapturedErrorCallbackInfo to requestDevice descriptor #297

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

beaufortfrancois
Copy link
Contributor

This PR adds uncapturedErrorCallbackInfo to requestDevice() descriptor to match recent Dawn changes at https://dawn-review.googlesource.com/c/dawn/+/183162.

It also removes wgpuDeviceSetUncapturedErrorCallback that will be deprecated with this new attribute.

Let me know if that looks good to you.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Please also cc @lokokung about changes to sync these headers, since he's usually the one who has implemented them in Dawn.)

webgpu.h Outdated Show resolved Hide resolved
@beaufortfrancois
Copy link
Contributor Author

@kainino0x Thanks for the review! I've addressed your feedback and will keep @lokokung updated about upcoming changes.

Note that I'll open a separate PR for WGPUDeviceLostCallbackInfo

@beaufortfrancois
Copy link
Contributor Author

WGPUDeviceLostCallbackInfo currently contains WGPUCallbackMode mode which is not yet defined in webgpu.h. I guess this means we need to wait a bit more before adding it to webgpu.h when WGPUFuture are actually defined. What do you think?

@kainino0x
Copy link
Collaborator

WGPUDeviceLostCallbackInfo currently contains WGPUCallbackMode mode which is not yet defined in webgpu.h. I guess this means we need to wait a bit more before adding it to webgpu.h when WGPUFuture are actually defined. What do you think?

Oh yes, fair point. I forgot DeviceLost is promise-based and UncapturedError is not. Makes sense to separate them then.

I am not sure how soon we'll be ready to roll in the promise changes, but I think we're very close. Maybe when we do that we should deal with the generator thing first before rolling all that in, but TBD.

@kainino0x kainino0x requested a review from rajveermalviya June 4, 2024 22:51
@kainino0x kainino0x merged commit 1d20ada into webgpu-native:main Jun 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants