Define depthWriteEnabled as WGPUOptionalBool #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kainino0x Can you review? |
beaufortfrancois
force-pushed
the
wgpuoptionalbool
branch
from
3628718 to
3b8c13d
Compare
kainino0x
reviewed
Jul 11, 2024
webgpu.h
Outdated
Comment on lines
411
to
413
| WGPUOptionalBool_Undefined = 0x00000000, | ||
| WGPUOptionalBool_False = 0x00000001, | ||
| WGPUOptionalBool_True = 0x00000002, |
There was a problem hiding this comment.
Should be False=0, True=1, Undefined=2
per #235 (comment)
There was a problem hiding this comment.
As raised in https://issues.chromium.org/issues/42241167#comment6, I've noticed Dawn asserts that "undefined" values must be 0 in dawn_json_generator.py. Shall we loosen this restriction in https://source.chromium.org/chromium/chromium/src/+/main:third_party/dawn/generator/dawn_json_generator.py;l=147;drc=83d3e7fc97d66a79c944c24b7ad18f549a5a150f?
There was a problem hiding this comment.
Oh yes, sorry I forgot to reply to that.
There's a strong reason to have False=0, True=1 so yes, I think we need to do that.
There was a problem hiding this comment.
@kainino0x I've updated this PR with your suggested changes.
…into wgpuoptionalbool
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 16, 2024
- No operational changes. webgpu-native/webgpu-headers#308 Bug: 42241167 Change-Id: I3874f99cf2c07d81cfededb1b92a8b138107eded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5683307 Commit-Queue: Loko Kung <[email protected]> Reviewed-by: Loko Kung <[email protected]> Reviewed-by: Austin Eng <[email protected]> Cr-Commit-Position: refs/heads/main@{#1343063}
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Aug 19, 2024
The following CLs must be merged before: - https://chromium-review.googlesource.com/c/chromium/src/+/5683307 - https://skia-review.googlesource.com/c/skia/+/874238 webgpu-native/webgpu-headers#308 Bug: 42241167 Change-Id: Ib6266b6981fb8caf38b734977ceaeeeed2cf55f9 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/197214 Reviewed-by: Austin Eng <[email protected]> Commit-Queue: Fr <[email protected]>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Aug 23, 2024
This reverts commit 8c230a7. Reason for revert: Probably causing roll failures on Windows build, example: https://ci.chromium.org/ui/p/chromium/builders/try/win-rel/727795/overview Original change's description: > [webgpu-headers] Define depthWriteEnabled as WGPUOptionalBool > > The following CLs must be merged before: > - https://chromium-review.googlesource.com/c/chromium/src/+/5683307 > - https://skia-review.googlesource.com/c/skia/+/874238 > > webgpu-native/webgpu-headers#308 > > Bug: 42241167 > Change-Id: Ib6266b6981fb8caf38b734977ceaeeeed2cf55f9 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/197214 > Reviewed-by: Austin Eng <[email protected]> > Commit-Queue: Fr <[email protected]> # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 42241167 Change-Id: I4fd367f0fb2b23ded925822ba238c64c43a9c3d3 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/203463 Reviewed-by: Austin Eng <[email protected]> Reviewed-by: Brandon Jones <[email protected]> Commit-Queue: Brandon Jones <[email protected]> Commit-Queue: Loko Kung <[email protected]>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Aug 27, 2024
Fixes the crash caused via ApplyClearColorValueWithDrawHelper not explicitly setting depthWriteEnabled to false. This is a reland of commit 8c230a7 Original change's description: > [webgpu-headers] Define depthWriteEnabled as WGPUOptionalBool > > The following CLs must be merged before: > - https://chromium-review.googlesource.com/c/chromium/src/+/5683307 > - https://skia-review.googlesource.com/c/skia/+/874238 > > webgpu-native/webgpu-headers#308 > > Bug: 42241167 > Change-Id: Ib6266b6981fb8caf38b734977ceaeeeed2cf55f9 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/197214 > Reviewed-by: Austin Eng <[email protected]> > Commit-Queue: Fr <[email protected]> Bug: 42241167 Change-Id: I18a1ae28d9df218da25dae57ad64c931e380221e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/203774 Commit-Queue: Loko Kung <[email protected]> Reviewed-by: Kai Ninomiya (OOO until 8月23日) <[email protected]>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Aug 28, 2024
The following CLs must be merged before: - https://chromium-review.googlesource.com/c/chromium/src/+/5687273/ - https://skia-review.googlesource.com/c/skia/+/874556 webgpu-native/webgpu-headers#308 Bug: 42241167 Change-Id: I79a827fc279ab25bff1d59a9b75771ff17887f84 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/197335 Reviewed-by: Corentin Wallez <[email protected]> Commit-Queue: Fr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #235