Use same order between LoadOp and StoreOp #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a minor consistency thing. This order is the same order it's written in the upstream JS spec (JS doesn't actually care about the order) as well as in Vulkan. Fixes 65
kainino0x
force-pushed
the
loadopstoreop
branch
from
bb0d3d2 to
f9bdf26
Compare
Kangz
approved these changes
Sep 2, 2024
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Sep 2, 2024
Just a minor consistency thing. This order is the same order it's written in the upstream JS spec (though JS doesn't actually care about the order) as well as in Vulkan. Upstream PR: webgpu-native/webgpu-headers#323 Upstream bug: webgpu-native/webgpu-headers#65 Bug: none Change-Id: Id70d99568c360225516acd347564d1b6de449d0c Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/204734 Auto-Submit: Kai Ninomiya <[email protected]> Commit-Queue: Corentin Wallez <[email protected]> Reviewed-by: Corentin Wallez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor consistency thing:
load,clear
store,discard
This order is the same order it's written in the upstream JS spec (though JS doesn't actually care about the order) as well as in Vulkan.
Fixes #65
Dawn change: https://dawn-review.googlesource.com/c/dawn/+/204734