Page Builder Elements - Compress Cached Data #4435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
changed the title
adrians5j
changed the title
adrians5j
changed the title
adrians5j
changed the title
adrians5j
changed the title
|
/cypress |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
|
/cypress |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
|
/cypress_node_20 |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
|
/cypress_node_20 |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
1 similar comment
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses a couple of
useLoaderReact hook-related issues.Mainly, when caching data into HTML (during page prerendering), the stringified JSON is now also encoded using
encodeURIComponent. This makes it easier to avoid any potential serialization/deserliazation issues that might occur because of special characters (managed to experience this while manually testing).Extra Changes
I noticed that the
WebsiteLoaderCacheclass was not instantiated at the proper place in thePageBuilderProviderHOCcomponent. This has now been fixed.I also had this change here, but realized it was causing some issues while E2E testing. B/c of lack of time, decided to not do this.
How Has This Been Tested?
Manually.
Documentation
Changelog.