Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB Elements - Replace render Prop With renderer #4444

Merged
merged 21 commits into from
Dec 13, 2024

Conversation

adrians5j
Copy link
Member

@adrians5j adrians5j commented Dec 12, 2024

Changes

This PR changes the render prop on new React component PB elements-related plugins to renderer.

For example, previously we had:

import React from "react";
import { PbRenderElementPlugin } from "@webiny/app-website";
import { SpaceX } from "./SpaceX";

export const Extension = () => <PbRenderElementPlugin elementType={"spaceX"} render={SpaceX} />;

Now we have:

import React from "react";
import { PbRenderElementPlugin } from "@webiny/app-website";
import { SpaceX } from "./SpaceX";

export const Extension = () => <PbRenderElementPlugin elementType={"spaceX"} renderer={SpaceX} />;

How Has This Been Tested?

Manually.

Documentation

Changelog.

@adrians5j adrians5j added this to the 5.41.4 milestone Dec 12, 2024
@adrians5j adrians5j marked this pull request as ready for review December 12, 2024 21:45
@adrians5j adrians5j changed the title Fix/pb elements data serialization with render PB Elements - Replace render Prop With Renderer Dec 12, 2024
@adrians5j adrians5j changed the title PB Elements - Replace render Prop With Renderer PB Elements - Replace render Prop With renderer Dec 12, 2024
@adrians5j adrians5j changed the base branch from fix/pb-elements-data-serialization to dev December 12, 2024 22:55
@adrians5j adrians5j merged commit bb1a258 into dev Dec 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant