Direct answers #45
Direct answers #45
Conversation
archive_query_log/orm.py
Outdated
| @@ -190,6 +190,18 @@ class Snippet(SnippetId): | |||
| text: str | None = Text() | |||
|
|
|||
|
|
|||
| class DirectAnswerId(InnerDocument): | |||
| id: str = Keyword() | |||
| rank: int = Integer() | |||
There was a problem hiding this comment.
Does a direct answer really have an interpretable "rank" (i.e., are the direct answers ordered in some way)?
- removed boxes and added url and text in DirectAnswer - changed xpath str to xpaths List[str]
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## elastic #45 +/- ##
========================================
Coverage 89.68% 89.68%
========================================
Files 61 61
Lines 2724 2724
========================================
Hits 2443 2443
Misses 281 281 ☔ View full report in Codecov by Sentry. |
archive_query_log/orm.py
Outdated
| @@ -461,9 +459,8 @@ class WarcDirectAnswerParser(BaseDocument): | |||
| url_pattern_regex: str | None = Keyword() | |||
| priority: float | None = RankFeature(positive_score_impact=True) | |||
| parser_type: WarcDirectAnswerParserType = Keyword() | |||
| xpath: str | None = Keyword() | |||
| xpaths: List[str] | None = Keyword() | |||
There was a problem hiding this comment.
As mentioned on Discord, we can just use one XPath with alternatives.
archive_query_log/imports/yaml.py
Outdated
There was a problem hiding this comment.
Hi Julian, actually, we don't need to have an importer for direct answer parsers as there are no such parsers in the "old" AQL. So you can just revert the changes in this file (which should fix most of the type-safety issues here).
| else: | ||
| raise ValueError(f"Invalid parser type: {parser_type}") | ||
| WarcDirectAnswersParser.init(using=config.es.client) | ||
| add_warc_direct_answers_parser( |
There was a problem hiding this comment.
The type-checker complains that a parameter is missing here.
No description provided.