fix: webpack compilations fail when using filesystem cache, #458 #459
Conversation
CHANGELOG.md
Outdated
| @@ -2,6 +2,13 @@ | |||
|
|
|||
| All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. | |||
|
|
|||
| ### [4.1.2](https://github.com/webpack-contrib/image-minimizer-webpack-plugin/compare/v4.1.1...v4.1.2) (2024-12-16) | |||
There was a problem hiding this comment.
Changelog is auto generated so dont modify that
There was a problem hiding this comment.
I have removed changes in package.json and CHANGELOG.md
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "image-minimizer-webpack-plugin", | |||
| "version": "4.1.1", | |||
| "version": "4.1.2", | |||
There was a problem hiding this comment.
@alexander-akait is the one bumping and publishing versions, so dont include that in this pr
webdiscus
force-pushed
the
fix-cache-filesystem2
branch
from
c213a30 to
b6fbf39
Compare
|
Thx. Could you write a reproduction repo with the bug, so we can compare results? I see that you've just added an extra check if resourcepath doesnt contain the data. |
in the issue #458 is the link to the repo: cache-filesystem-rebuild-image-minimizer The steps "How to reproduce the bug" are described in the #458 |
|
great. thank you! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 77.16% 77.85% +0.68%
==========================================
Files 4 4
Lines 727 754 +27
Branches 282 303 +21
==========================================
+ Hits 561 587 +26
- Misses 137 138 +1
Partials 29 29 ☔ View full report in Codecov by Sentry. |
|
Do it better - #460, anyway big thank you |
|
after update to |
This PR contains a:
Motivation / Use-Case
There is the Bugfix for the issue Webpack compilations fail when using filesystem cache.
Breaking Changes
Additional Info