Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error and warning messages in overlay #4087

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Refers #3689

improve error and warning messages in overlay.

Breaking Changes

None

Additional Info

No

@snitin315 snitin315 force-pushed the improve-overlay-message branch from b0d7246 to 478b963 Compare December 9, 2021 11:06
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's add more tests

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #4087 (3d8c2d4) into master (eea50f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4087   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files          16       16           
  Lines        1593     1593           
  Branches      596      596           
=======================================
  Hits         1470     1470           
  Misses        114      114           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea50f3...3d8c2d4. Read the comment docs.

@snitin315
Copy link
Member Author

Looks good, let's add more tests

yes, WIP on tests

@snitin315 snitin315 force-pushed the improve-overlay-message branch from 478b963 to b78547a Compare April 17, 2022 02:03
@snitin315 snitin315 marked this pull request as ready for review April 17, 2022 02:26
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more tests?

@snitin315
Copy link
Member Author

Yes, can you suggest some test cases?

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create errors in custom plugin with module name, message, file and etc, will be great to have even real problems from webpack, just create situation when webpack throws them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants