Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the inclusion of a custom theme when using --static #458

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

MartenBE
Copy link
Contributor

This fixes #439 for me.

@MartenBE MartenBE mentioned this pull request Sep 15, 2023
@MartenBE
Copy link
Contributor Author

I have tested this in the mean time with both a local css file, and a remote css file using a https://... link. Both seem to work fine.

@nuke-web3
Copy link

@MartenBE thanks for this! Sadly you branch doesn't work for me in https://github.com/Polkadot-Blockchain-Academy/pba-book - the css is missing from the bun serve-slides command, I am sure I have something mangled vs what is "right" for the reveal-md settings and mapping them to files I need in the build and/or serve.

@MartenBE
Copy link
Contributor Author

MartenBE commented Sep 26, 2023

@nukemandan I've checked your PR and dived deeper in the code, I've combined it to this. This solution has been tested with a css file and an css link. It seems to work for both static (listing and chapter) and watch. Could you recheck if this works?

Copy link

@nuke-web3 nuke-web3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup! Now your branch seems to do the trick for me 😁

@MartenBE MartenBE requested a review from nuke-web3 September 27, 2023 15:54
@MartenBE
Copy link
Contributor Author

Nice, I fixed a unit test regression and formatted the code to spec. If it runs ok for you, it is ready to go.

@MartenBE
Copy link
Contributor Author

MartenBE commented Oct 4, 2023

@nukemandan let me know if you have reviewed the code, I'll ask for the maintainer to merge it then.

@webpro
Copy link
Owner

webpro commented Oct 4, 2023

Thanks, planning to review and go through some issues and pull requests this weekend.

@MartenBE
Copy link
Contributor Author

MartenBE commented Oct 17, 2023

@webpro Is there any update on this? I would like to deploy using github pages to show my colleagues about reveal-md, but this prevents me from doing that unfortunately: the result with the "missing" custom css file isn't appealing.

@webpro webpro merged commit b1481e0 into webpro:main Oct 24, 2023
1 check failed
@webpro
Copy link
Owner

webpro commented Oct 24, 2023

Thanks @MartenBE and @nukemandan! This is included in v5.5.2

@MartenBE
Copy link
Contributor Author

@webpro Thank you very much for the update! For my colleagues I created following test case: https://hogenttin.github.io/hogent-revealmd/ . It shows a how to use intro, basic examples and even advanced examples such as iframes, fragments and multicolumn layout. It also demonstrates autodeployment using Github Actions and support for linting and dead link checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--static with --theme generate the index.html with the wrong path of theme.css
3 participants