-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the inclusion of a custom theme when using --static
#458
Conversation
…ad of an absolute path for the theme.
I have tested this in the mean time with both a local css file, and a remote css file using a |
@MartenBE thanks for this! Sadly you branch doesn't work for me in https://github.com/Polkadot-Blockchain-Academy/pba-book - the css is missing from the |
@nukemandan I've checked your PR and dived deeper in the code, I've combined it to this. This solution has been tested with a css file and an css link. It seems to work for both static (listing and chapter) and watch. Could you recheck if this works? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup! Now your branch seems to do the trick for me 😁
Nice, I fixed a unit test regression and formatted the code to spec. If it runs ok for you, it is ready to go. |
@nukemandan let me know if you have reviewed the code, I'll ask for the maintainer to merge it then. |
Thanks, planning to review and go through some issues and pull requests this weekend. |
@webpro Is there any update on this? I would like to deploy using github pages to show my colleagues about |
Thanks @MartenBE and @nukemandan! This is included in v5.5.2 |
@webpro Thank you very much for the update! For my colleagues I created following test case: https://hogenttin.github.io/hogent-revealmd/ . It shows a how to use intro, basic examples and even advanced examples such as iframes, fragments and multicolumn layout. It also demonstrates autodeployment using Github Actions and support for linting and dead link checking. |
This fixes #439 for me.