Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for pdf print instructions #472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Zacaria
Copy link

@Zacaria Zacaria commented Dec 9, 2023

Hi !

I was trying to print my presentation, but I found out the documentation is outdated.

Thank you for your tool !

@webpro
Copy link
Owner

webpro commented Jan 2, 2024

Thanks, @Zacaria!

Are you on the latest version of reveal-md? The docs were updated to match the Reveal.js v5 update.

@Zacaria
Copy link
Author

Zacaria commented Jan 2, 2024

Oh, it's true that I didn't see the changelog.

However I just checked again, on my project : https://github.com/Zacaria/apidays-2023 I have version 5.5.2

?view=print gives me this result

Screenshot 2024-01-02 at 20 04 20

?print-pdf gives me this result

Screenshot 2024-01-02 at 20 04 39

Then I believe it's more an issue than a missing documentation

I leave it up to you to close this PR :)

Do you want me to try and fix it ?

@webpro
Copy link
Owner

webpro commented Jan 2, 2024

Do you want me to try and fix it ?

I would love that! Personally I'm not using the print/PDF functionality at all.

@webpro webpro force-pushed the main branch 2 times, most recently from eb6481b to a2f61db Compare August 31, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants