Use valid mimetype for HEVC/H.264/AV1 and add hev1/avc3 mimetypes
#1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on conversation with Chrome Media Team, we should only support valid mimetype for future new codecs like HEVC. For HEVC/H.264/AV1, it is recommend to use valid mimetype instead of just `hvc1`, `avc1` or `av01`. There are some limitation for `avc1` / `hvc1` as they only allow "out of band parameter sets", so if capture device can produce dynamic resolution video stream, only `avc3` / `hev1` can satisfy the needs as they supports "in band parameter sets". Chromium may support `hev1` and `avc3` in the future, so also added these mimetypes for future testing.
|
cc @handellm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on conversation with Chrome Media Team, we should only support valid mimetype for future new codecs like HEVC.
For HEVC/H.264/AV1, it is recommend to use valid mimetype instead of just
hvc1,avc1orav01.There are some limitation for
avc1/hvc1as they only allow "out of band parameter sets", so if capture device can produce dynamic resolution video stream, onlyavc3/hev1can satisfy the needs as they supports "in band parameter sets".Chromium may support
hev1andavc3in the future, so also added these mimetypes for future testing.