Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition Blob URL fetches by Storage Key #1783

Merged
merged 11 commits into from
Dec 9, 2024
Merged

Partition Blob URL fetches by Storage Key #1783

Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
42a4f90
Partition Blob URL fetches by Storage Key
recvfrom Oct 25, 2024
2d4567d
Fix formatting per the style guide
recvfrom Oct 25, 2024
e7689d6
Fix build and formatting
recvfrom Oct 25, 2024
f4f62bf
Add name to Acknowledgements section
recvfrom Oct 25, 2024
d79ae96
Address review feedback
recvfrom Nov 22, 2024
0d6d692
Move storage key check logic to FileAPI
recvfrom Nov 25, 2024
cacc4e5
Refactor existing use of blob URL entry object
recvfrom Nov 25, 2024
2f71ba0
Address review feedback
recvfrom Nov 28, 2024
c201d79
Fix reference to 'Obtain a blob URL'
recvfrom Dec 5, 2024
0b5fccb
Simplify based on review feedback
recvfrom Dec 6, 2024
ddae2dc
Minor text wrapping change for consistency
recvfrom Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions fetch.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3133,6 +3133,32 @@ or an <a>implementation-defined</a> value.
</div>


<h3 id=storage-keys-for-requests>Storage keys for requests</h3>

<p class=note>Requests made to Blob URLs (other than those corresponding to navigations) are
prevented from succeeding if the <a spec=storage>storage key</a> of the
<a>environment settings object</a> making the request is different than the
<a spec=storage>storage key</a> of the <a>environment settings object</a> corresponding to where
the Blob URL was created.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it would work better after line 5028, instead of near this algorithm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking this would make sense in the Infrastructure section like how the HTTP cache partitioning section and determine the HTTP cache partition algorithm are, but I've moved the algorithm under the Scheme fetch section now (and removed the note since it seems kinda out of place now. WDYT?


<div algorithm>
<p>To <dfn for=request>determine the storage key</dfn>, given a <a for=/>request</a>
<var>request</var>:

<ol>
<li><p>If <var>request</var>'s <a for=request>reserved client</a> is non-null, then return the
result of running <a for=/>obtain a storage key for non-storage purposes</a> given
<var>request</var>'s <a for=request>reserved client</a>.

<li><p>If <var>request</var>'s <a for=request>client</a> is non-null, then return the result of
running <a for=/>obtain a storage key for non-storage purposes</a> given <var>request</var>'s
<a for=request>client</a>.

<li><p>Return null.
</ol>
</div>


<h3 id=http-cache-partitions>HTTP cache partitions</h3>

<div algorithm>
Expand Down Expand Up @@ -4978,6 +5004,29 @@ steps:
<p class=note>The `<code>GET</code>` <a for=/>method</a> restriction serves no useful purpose
other than being interoperable.

<li>
recvfrom marked this conversation as resolved.
Show resolved Hide resolved
<p>Let <var>blobStorageKey</var> be the result of running
<a>obtain a storage key for non-storage purposes</a> with <var>blobURLEntry</var>'s
<a>environment settings object</a>.
recvfrom marked this conversation as resolved.
Show resolved Hide resolved

<li>
<p>Let <var>requestStorageKey</var> be the result of
<a for=request>determining the storage key</a> given <var>request</var>.

<li>
<p>If all of the following conditions are true:

<ul class=brief>
<li><p><var>request</var>'s <a for=request>mode</a> is not "<code>navigate</code>"
recvfrom marked this conversation as resolved.
Show resolved Hide resolved

<li><p><var>requestStorageKey</var> is non-null
recvfrom marked this conversation as resolved.
Show resolved Hide resolved

<li><p><var>requestStorageKey</var> does not <a for="storage key">equal</a>
<var>blobStorageKey</var>
recvfrom marked this conversation as resolved.
Show resolved Hide resolved
</ul>

<p>then return a <a>network error</a>.

<li><p>Let <var>blob</var> be <var>blobURLEntry</var>'s <a for="blob URL entry">object</a>.

<li><p>Let <var>response</var> be a new <a for=/>response</a>.
Expand Down Expand Up @@ -9042,6 +9091,7 @@ Alexey Proskuryakov,
Andreas Kling,
Andrés Gutiérrez,
Andrew Sutherland,
Andrew Williams,<!-- recvfrom; GitHub -->
Ángel González,
Anssi Kostiainen,
Arkadiusz Michalski,
Expand Down