Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Upstream innerHTML property from DOM Parsing spec #10264

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Apr 9, 2024

This includes the innerHTML property on Element and ShadowRoot.

The fragment serializing algorithm steps and fragment parsing algorithm steps are also upstreamed.

See w3c/DOM-Parsing#79 for associated DOM Parsing PR to remove these.


/dynamic-markup-insertion.html ( diff )
/form-control-infrastructure.html ( diff )
/index.html ( diff )
/infrastructure.html ( diff )
/parsing.html ( diff )
/scripting.html ( diff )

source Show resolved Hide resolved
@lukewarlow lukewarlow force-pushed the domparsing-innerhtml branch from 13a2012 to c4c9daa Compare April 9, 2024 15:33
@lukewarlow
Copy link
Member Author

lukewarlow commented Apr 9, 2024

w3c/DOM-Parsing#78 (comment) @annevk mentioned here an XXX marker for the issues.

What would be the best format for this? Just a paragraph linking to the various github issues in the DOM parsing spec repo? A paragraph explaining that this spec might not properly match implementations?

@lukewarlow
Copy link
Member Author

I believe this is editorial because it's just moving something from another spec? Rather than being something new and normative?

This includes the innerHTML property on Element and ShadowRoot.

The fragment serializing algorithm steps and fragment parsing algorithm steps are also upstreamed.
@lukewarlow lukewarlow force-pushed the domparsing-innerhtml branch from 6e34f11 to a5a03fb Compare April 10, 2024 13:02
@lukewarlow lukewarlow changed the title Upstream innerHTML from DOM Parsing spec Editorial: Upstream innerHTML property from DOM Parsing spec Apr 10, 2024
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this!

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@domenic
Copy link
Member

domenic commented Apr 11, 2024

w3c/DOM-Parsing#78 (comment) @annevk mentioned here an XXX marker for the issues.

What would be the best format for this? Just a paragraph linking to the various github issues in the DOM parsing spec repo? A paragraph explaining that this spec might not properly match implementations?

Probably something like what we have in #the-javascript:-url-special-case, linking to the issue tracker, indeed.

A full upstreaming job would consist of going through all the open issues, determining which of them are accurate, and then re-filing them on whatwg/html (with some specific label). That would allow us to truly sunset the DOMParsing repo.

@lukewarlow
Copy link
Member Author

One possibility is maybe we can transfer the issues directly to this repository. Mark them as needing triage and then we can at least drop the old spec without needing to do all that work up front?

@lukewarlow lukewarlow force-pushed the domparsing-innerhtml branch from d88632e to ea4caba Compare April 11, 2024 10:56
@lukewarlow
Copy link
Member Author

I think I've addressed all bar 1 of your comments. I've not added the XXX block yet to see what you think of the idea of just transferring the issues across (in which case we can give them a label and just refer to it like you mentioned that javascript URLs do)

@lukewarlow
Copy link
Member Author

idea of just transferring the issues across

Having said that we'd either have to do some of them at a time, or wait till the whole spec is upstreamed. So maybe we should just make a "DOMParsing" label on the issue tracker and link to it?

@lukewarlow lukewarlow requested a review from domenic April 11, 2024 17:03
@domenic
Copy link
Member

domenic commented Apr 12, 2024

I would rather manually port the issues, ideally checking if they're valid at the same time, since the entire contents of the issue thread are not really valuable, but instead a clear problem description would be more useful.

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@lukewarlow
Copy link
Member Author

I've addressed those comments and added an XXX marker that's hopefully okay. Happy to reword it if you have any suggestions :)

@lukewarlow lukewarlow requested a review from domenic April 12, 2024 13:17
@domenic domenic merged commit d6a5f09 into whatwg:main Apr 15, 2024
2 checks passed
@domenic domenic added addition/proposal New features or enhancements topic: parser labels Apr 15, 2024
@lukewarlow lukewarlow deleted the domparsing-innerhtml branch April 15, 2024 10:06
domenic pushed a commit to w3c/DOM-Parsing that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition/proposal New features or enhancements topic: parser
Development

Successfully merging this pull request may close these issues.

2 participants