-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Upstream innerHTML property from DOM Parsing spec #10264
Conversation
13a2012
to
c4c9daa
Compare
w3c/DOM-Parsing#78 (comment) @annevk mentioned here an XXX marker for the issues. What would be the best format for this? Just a paragraph linking to the various github issues in the DOM parsing spec repo? A paragraph explaining that this spec might not properly match implementations? |
c4c9daa
to
d89cec4
Compare
d89cec4
to
6e34f11
Compare
I believe this is editorial because it's just moving something from another spec? Rather than being something new and normative? |
This includes the innerHTML property on Element and ShadowRoot. The fragment serializing algorithm steps and fragment parsing algorithm steps are also upstreamed.
6e34f11
to
a5a03fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for working on this!
Probably something like what we have in A full upstreaming job would consist of going through all the open issues, determining which of them are accurate, and then re-filing them on whatwg/html (with some specific label). That would allow us to truly sunset the DOMParsing repo. |
One possibility is maybe we can transfer the issues directly to this repository. Mark them as needing triage and then we can at least drop the old spec without needing to do all that work up front? |
d88632e
to
ea4caba
Compare
I think I've addressed all bar 1 of your comments. I've not added the XXX block yet to see what you think of the idea of just transferring the issues across (in which case we can give them a label and just refer to it like you mentioned that javascript URLs do) |
Having said that we'd either have to do some of them at a time, or wait till the whole spec is upstreamed. So maybe we should just make a "DOMParsing" label on the issue tracker and link to it? |
I would rather manually port the issues, ideally checking if they're valid at the same time, since the entire contents of the issue thread are not really valuable, but instead a clear problem description would be more useful. |
I've addressed those comments and added an XXX marker that's hopefully okay. Happy to reword it if you have any suggestions :) |
These have been moved to the HTML Standard in whatwg/html#10264.
This includes the innerHTML property on Element and ShadowRoot.
The fragment serializing algorithm steps and fragment parsing algorithm steps are also upstreamed.
See w3c/DOM-Parsing#79 for associated DOM Parsing PR to remove these.
/dynamic-markup-insertion.html ( diff )
/form-control-infrastructure.html ( diff )
/index.html ( diff )
/infrastructure.html ( diff )
/parsing.html ( diff )
/scripting.html ( diff )