Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 #69

Merged
merged 10 commits into from
Nov 21, 2024
Merged

V5 #69

merged 10 commits into from
Nov 21, 2024

Conversation

whikloj
Copy link
Owner

@whikloj whikloj commented Nov 21, 2024

No description provided.

* Remove support of PHP < 8.0

* More changes

* Add version 5 action
* Add addTagFile()

* Add removeTagFile and tests

* Build pushed feature branches

* Update action versions

* Fix messages

* Cover the new private function shared by addTagFile and removeTagFile
* Initial BagItProfile work

* More testing

* More tests

* Track serializations

* Load and validate profiles

* Return file path in archive type exception

* Windows test

* Clean up extension handling

* Add more profile tests

* Fixes and more profile tests

* Always check for Allow-Fetch before Require-Fetch, so the reverse test is unnecessary

* Fix callable in array_filter

* Move json into tests

* More tests

* Add methods to add profile to bag and some tests

* Allow other bag-info tag options

* Test bag is valid before creating a package

* Read BagIt Profile identifiers from bag-info.txt and validate

Additional tests

Handle long lines without a space to break at

* Add a change log

* Some tidying

* Correct PIPEWAIT and add test for trait
* Clean up for PHPStan level 7

* Clean up some testing
This reverts commit bd2b380.
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 79.71204% with 155 lines in your changes missing coverage. Please review.

Project coverage is 84.90%. Comparing base (9f72e2e) to head (4b7da56).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Profiles/BagItProfile.php 71.73% 104 Missing ⚠️
src/Bag.php 82.94% 29 Missing ⚠️
src/Profiles/ProfileFactory.php 68.42% 6 Missing ⚠️
src/BagUtils.php 87.17% 5 Missing ⚠️
src/CurlInstance.php 90.69% 4 Missing ⚠️
src/DownloadFile.php 88.23% 4 Missing ⚠️
src/Commands/ValidateCommand.php 75.00% 2 Missing ⚠️
src/Fetch.php 97.95% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #69      +/-   ##
============================================
- Coverage     89.54%   84.90%   -4.65%     
- Complexity      486      716     +230     
============================================
  Files             7       12       +5     
  Lines          1387     1941     +554     
============================================
+ Hits           1242     1648     +406     
- Misses          145      293     +148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@whikloj whikloj merged commit d9c877f into main Nov 21, 2024
14 of 17 checks passed
@whikloj whikloj deleted the v5 branch November 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant