ISSUE-462: Add rexml dependency for Ruby 3.0.0+ #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanVqz
reviewed
Oct 2, 2023
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| * [CHANGE] Fix test warning related to `cucumber_opts` declaration (by [@faisal][]) | |||
| * [BUGFIX] Stop using long-deprecated MiniTest module name, removed in 5.19.0 (by [@faisal][]) | |||
| * [CHANGE] Add rexml dependency for Ruby 3.0.0+ (by [@fbuys][]) | |||
There was a problem hiding this comment.
Did you add yourself at the bottom of the file?
There was a problem hiding this comment.
Checks failing because https://docs.rubocop.org/rubocop/cops_gemspec.html#gemspecrubyversionglobalsusage -> https://rubystyle.guide/#no-ruby-version-in-the-gemspec
Is checking the Ruby version worth it? I believe Bundler should use the installation-provided rexml if we don't care about its version. If we do care about the rexml version then we should care about it regardless of Ruby version.
nunosilva800
approved these changes
Oct 3, 2023
fbuys
force-pushed
the
fbuys/462-support-ruby-3-2-2
branch
3 times, most recently
from
9ef5095 to
6ce85e2
Compare
We add rexml as a runtime dependency for environments that make use of Ruby 3 and up See: https://stackoverflow.com/a/65480744 Issue: whitesmith#462
fbuys
force-pushed
the
fbuys/462-support-ruby-3-2-2
branch
from
6ce85e2 to
b4595cc
Compare
faisal
approved these changes
Oct 5, 2023
JuanVqz
approved these changes
Oct 5, 2023
|
@nunosilva800 can we merge? |
etagwerker
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add rexml as a runtime dependency for environments that make use of Ruby 3 and up.
See: https://stackoverflow.com/a/65480744
Issue: #462
rexml does not add any additional dependencies: https://rubygems.org/gems/rexml.
I did test that this works with Ruby 3.2.2 and Ruby 2.7.8.
Check list: